Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4194547ybg; Mon, 8 Jun 2020 01:16:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFYGGyoYSboU4kxawB3jeHlwe0Vv7xXSkmvjIqHUpJMogQ+g29sLBNuZgXPfPD23JA1pnb X-Received: by 2002:a17:906:d111:: with SMTP id b17mr19580963ejz.267.1591604194664; Mon, 08 Jun 2020 01:16:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591604194; cv=none; d=google.com; s=arc-20160816; b=eOG3nnWcgKDEO89wlL+rYer5dSRreSp2FYVC3Eb2XhAmwbYe4nOjZiLnwTehLwND8C nrGRkYqF672N1zZmmxM0sqI4tn8l17BwkD6hab6H7KZD4/dzOE+QJ/rsgsJM2GiMPM4t ZdVU4QsmrV7gZH0FUQNLN+1GAQtA2oh1iJbLEzV88ISAP4ESp05KgnqVwFGf4fxrKyyn y3iYZuBJorsY9ZKdWXKS+8VOs1DHlyg0BdzQsD52CmvdLMVYwn4hHVahD8LBg4OwYZa4 Rvr0b1yrwDk3sSMyThKSpbz9mrSde8oQfcflMLly2goyZcYNf8ER6G06FQBrEiYf+GeP PZMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=5bMhj6PRA8TgsfO7ODtkOb2H25pCckv0n31sQwpU+9E=; b=IxT4Spox/JpMQiFy/uMbLRFr+R4K3/6+AV4o8AsFWzijyYQH9Cn5TcM2UUv+091HGy UwT+Oo1nLRX7BbvNPMDBLMHUX2je1tR7z2+yAMMAx3UAYcJlQGh16XkzQ2qiW/fM4VPS M7OZTDEeAgDxGy7iYhiPUmfP7HGL4YDw5GygtFT8ib+s5xIwTKiCHP/MwFFpSia2J5uo JN9keGihpCT0DgxnM0eTr1XkRZnJdswOlEBQzPGLWXA9TMpNiQ28O3Ir58RqXghPXiU0 /yTb8VFZYwyusUoebVBgOC7BQpQcw/n8flsPYZVEOlbLMvnAvg5SIGJDIASxZB7kCRRK NtOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n16si8527923eja.95.2020.06.08.01.16.10; Mon, 08 Jun 2020 01:16:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729082AbgFHIO5 (ORCPT + 99 others); Mon, 8 Jun 2020 04:14:57 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:48005 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729060AbgFHIO4 (ORCPT ); Mon, 8 Jun 2020 04:14:56 -0400 Received: from marcel-macpro.fritz.box (p5b3d2638.dip0.t-ipconnect.de [91.61.38.56]) by mail.holtmann.org (Postfix) with ESMTPSA id CC6E3CEC82; Mon, 8 Jun 2020 10:24:43 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH 3/3] Bluetooth: hci_qca: Refactor error handling in qca_suspend() From: Marcel Holtmann In-Reply-To: <20200605114552.3.Ib9b5e6e81ea31cdc964cd0562ef4985a6c6c5154@changeid> Date: Mon, 8 Jun 2020 10:14:54 +0200 Cc: Johan Hedberg , linux-bluetooth@vger.kernel.org, Rocky Liao , Zijun Hu , linux-kernel@vger.kernel.org, Balakrishna Godavarthi , Abhishek Pandit-Subedi , Claire Chang Content-Transfer-Encoding: 7bit Message-Id: <7C70D49B-16CE-4299-8E35-78FA0668FF65@holtmann.org> References: <20200605184611.252218-1-mka@chromium.org> <20200605114552.3.Ib9b5e6e81ea31cdc964cd0562ef4985a6c6c5154@changeid> To: Matthias Kaehlcke X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Matthias, > If waiting for IBS sleep times out jump to the error handler, this is > easier to read than multiple 'if' branches and a fall through to the > error handler. > > Signed-off-by: Matthias Kaehlcke > --- > > drivers/bluetooth/hci_qca.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel