Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: /9CfQGRtO74Eg3q1nxAo5lKguDFTU8QKXz4TWPRXM8/I78ATX9fkdXCBFtZ2BhmhnN40YY+/nO
 RL2QwnopoFNQ==
IronPort-SDR: Z4dr5mS1HcJ7h5cofT/23RbibhlIqzv5+7U2vkBTrmicrmrNUTZHbFgEc+hWXya18VRF5gV2Er
 8LJEW8ivlE6A==
From:   "K, Kiran" <kiran.k@intel.com>
To:     Marcel Holtmann <marcel@holtmann.org>
CC:     Bluez mailing list <linux-bluetooth@vger.kernel.org>,
        "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
        "Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>,
        "Ps, AyappadasX" <ayappadasx.ps@intel.com>
Subject: RE: [PATCH v2 1/2] Bluetooth: Add support to Intel read supported
 feature
Thread-Topic: [PATCH v2 1/2] Bluetooth: Add support to Intel read supported
 feature
Thread-Index: AQHWOY/UABzTnqYEH0Kk/r9P5cMu7KjHKYkAgAeFqZA=
Date:   Mon, 8 Jun 2020 12:38:25 +0000
Message-ID: <BYAPR11MB314161FEA3408E8CE560AC5CF5850@BYAPR11MB3141.namprd11.prod.outlook.com>
References: <20200603101523.12547-1-kiran.k@intel.com>
 <E929E0E0-E28A-4874-B168-A5E03C40F1F8@holtmann.org>
In-Reply-To: <E929E0E0-E28A-4874-B168-A5E03C40F1F8@holtmann.org>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4eb0b82a-bb1f-48a1-1069-08d80ba8d683
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2020 12:38:25.1771
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0DOvywy6AdT0jZ6f2AqZimdN0Y3W/ZCFInr3ePtX3NQejBnaeqtyudKWXgZbObKe8YwAzNdjG5wxWPItZft63w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3813
X-OriginatorOrg: intel.com
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Marcel,

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org <linux-bluetooth-
> owner@vger.kernel.org> On Behalf Of Marcel Holtmann
> Sent: Wednesday, June 3, 2020 11:12 PM
> To: K, Kiran <kiran.k@intel.com>
> Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>; Srivatsa, Ravis=
hankar
> <ravishankar.srivatsa@intel.com>; Tumkur Narayan, Chethan
> <chethan.tumkur.narayan@intel.com>; Ps@vger.kernel.org; Ps, AyappadasX
> <ayappadasx.ps@intel.com>
> Subject: Re: [PATCH v2 1/2] Bluetooth: Add support to Intel read supporte=
d
> feature
>=20
> Hi Kiran,
>=20
> > The command shall read the Intel controller supported feature. Based
> > on the supported features addtional debug configuration shall be
> > enabled.
> >
> > Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> > Signed-off-by: Ps, AyappadasX <AyappadasX.Ps@intel.com>
> > Signed-off-by: Kiran K <kiran.k@intel.com>
> > ---
> > drivers/bluetooth/btintel.c | 34 ++++++++++++++++++++++++++++++++++
> > drivers/bluetooth/btintel.h | 14 ++++++++++++++
> > drivers/bluetooth/btusb.c   |  8 +++++++-
> > 3 files changed, 55 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> > index 6a0e2c5a8beb..09e697b92426 100644
> > --- a/drivers/bluetooth/btintel.c
> > +++ b/drivers/bluetooth/btintel.c
> > @@ -754,6 +754,40 @@ void btintel_reset_to_bootloader(struct hci_dev
> > *hdev) } EXPORT_SYMBOL_GPL(btintel_reset_to_bootloader);
> >
> > +int btintel_read_supported_features(struct hci_dev *hdev,
> > +	struct intel_supported_features *supported_features) {
> > +	struct sk_buff *skb;
> > +	u8 page_no =3D 1;
> > +
> > +	/* Intel controller supports two pages, each page is of 128-bit
> > +	 * feature bit mask. And each bit defines specific feature support
> > +	 */
> > +	skb =3D __hci_cmd_sync(hdev, 0xfca6, sizeof(page_no), &page_no,
> > +		HCI_INIT_TIMEOUT);
>=20
> Please get the coding style right first. We have plenty of examples in th=
e same
> file on how to do this.

I have addressed all the issues reported  by 'checkpatch.pl  --strict' and =
sent updated patches.  Thanks.

>=20
> Regards
>=20
> Marcel