Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp465538ybg; Fri, 12 Jun 2020 06:21:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxV4cdpbE0c2AA+8+LByzPacI2lSOdWI7iDpPjACUJv31vG4T7bbWX853A9yMO2JKfNNViw X-Received: by 2002:a17:906:ce31:: with SMTP id sd17mr13133713ejb.255.1591968065483; Fri, 12 Jun 2020 06:21:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591968065; cv=none; d=google.com; s=arc-20160816; b=idMi1u9FXDmyi7g5OF87DorymAYjGAEt4wm20fgcVq4+CSKbdGO3o/pqn1LwD7Y4Lz BjqtQVaZK1jmQeGAFQPlN84Y7xHLdIGEiLbBnq9hl6c9yfiFoIgKu7ywkhi8MLCByxdT 5Gw904bauZJy5J006U+IQfnvYkho3wGfYe8eLBqUGFpeJhUIhoKXlzdLbkfzmHa491ET hp0zn2i583THkZtB8XMDyfyYwrKy9VqMMwiG+KtysXcA8u+saoaa5Fz342vcKzSEZvFc BmnRzhTXfRMqXqPq6gXXu+WWx6YSfp1lkys1rs8E4E17xnxzB4awEovv+UXI5wcLqBvf 7V8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=e5IWTv4DOamHF9AeyKbf6cS5gQOO0m+35b8DuYYEojk=; b=CNBnhiP+c/ERS2o2LQGTj9ebvxaOkWhYYNPvSenVjbfNkxUq29VkA+pNOlyq94Kp8L eB+xIjozDh3qfvPm+43q6qDJLzLNHwZ8tVGpiYVjfOvcer2OZHR+Dec4wo+cqstp8NhX 19E9Huxs8ZhvLtQmvrHHVqPBLk1vWBd9J3BTUh0CCyjIVORpxSrPkfSlCQCImE0xT4vw DFaBWJ2L7X5geLYSqvIKW8zvQxMo4ATztteraevSxdrhG4+HoRBT3oP0NfSwPizL9wyR mwToeaYn/sFDfVchdqf7qAZ1+PIqp96hY1le0hSAda1wItBbLu7OsK3Vs/KmbdCTb34p VkLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x24si3852762ejs.448.2020.06.12.06.20.41; Fri, 12 Jun 2020 06:21:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726479AbgFLNTf (ORCPT + 99 others); Fri, 12 Jun 2020 09:19:35 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:60228 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbgFLNTf (ORCPT ); Fri, 12 Jun 2020 09:19:35 -0400 Received: from marcel-macbook.fritz.box (ip-109-41-64-170.web.vodafone.de [109.41.64.170]) by mail.holtmann.org (Postfix) with ESMTPSA id 64E66CED03; Fri, 12 Jun 2020 15:29:22 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH v1] Bluetooth: hci_qca: Request Tx clock vote off only when Tx is pending From: Marcel Holtmann In-Reply-To: <1591964117-8228-1-git-send-email-bgodavar@codeaurora.org> Date: Fri, 12 Jun 2020 15:19:30 +0200 Cc: Johan Hedberg , mka@chromium.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org, abhishekpandit@chromium.org, rjliao@codeaurora.org, gubbaven@codeaurora.org Content-Transfer-Encoding: 7bit Message-Id: <29DD7F7E-A91D-439D-9FAA-23C8A16BD586@holtmann.org> References: <1591964117-8228-1-git-send-email-bgodavar@codeaurora.org> To: Balakrishna Godavarthi X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Balakrishna, > Tx pending flag is set to true when HOST IBS state is AWAKE or > AWAKEING. If IBS state is ASLEEP, then Tx clock is already voted > off. To optimize further directly calling serial_clock_vote() > instead of qca_wq_serial_tx_clock_vote_off(), at this point of > qca_suspend() already data is sent out. No need to wake up hci to > send data. > > Signed-off-by: Balakrishna Godavarthi > --- > drivers/bluetooth/hci_qca.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel