Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp483882ybg; Fri, 12 Jun 2020 06:48:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXiaKz96YLYkPi3wwfNdo7BYA6QI9vb96pxu+0DBKkjNiV8Si4Xk1Ej1EVo3gmPuJ6NDXV X-Received: by 2002:a05:6402:2207:: with SMTP id cq7mr12238208edb.186.1591969709737; Fri, 12 Jun 2020 06:48:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591969709; cv=none; d=google.com; s=arc-20160816; b=hWhzKw4rQtE9JEJQT1KIgQ0g1apN7qEabQpOJy/+EhprYcyCYYcyGevpzkXbNIF1Wo nDH3MvT62Gz8HOd91Fi2RfYLOfArFUUb06y6HrvRZx/59nciIl87ha9LYTch78id3ahy iftgJNbuqoTR56STEGgW0w+puifPCR/tac5YuU1HOdUhMgn4xJqUMi0UXMAQKBzRUa7m 5IjpvTd7lkWupOQL40HfALrC5aX6nozTt9cZaL3LZgvFIPPgJGynZZfWEXfAOT2Od8VU 76Hs3mx7NgAmsWxhr1ujJBofqYMpEoN7j7hOTB2ARx0IVpqDE/jeLvJxpkVt/GyxDrmn QCTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=janrSB53n8v6quIls0rOEFskY9x+/BKvnNHIQ2er3Fc=; b=yZ0LzE4vfi+7gdVHakwc4XiltD/JCFn9Qr9kSS0YOtpMjyLJi0aPQH3qHsI953WMLs lzTYcmDHjY9GCD0eDhJ6Nra2TjEtNbGtINO25pR2xCp25Q+oFeCpCxpjx5Z2KtrAw4c7 dii8bioyBPmUEndSIngSm3AuCEfiWTibJ8XBt/r+bHEDsPD1hcoRgLQKWZxi9atVfocU cWJD+39+ykB8McKHlE1Aml+GAxCmGIJqJs6f5hoI3zCtraPsUG7/B8W18BM+uMFfpC/U 6cMEYy0n/jXPjq21aeagja51OS2l3xkDjJKTv1yz+ZN7XUikWfuZg/Lm/0g+Hj28CQg5 sVhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ci9si3862630ejb.218.2020.06.12.06.48.05; Fri, 12 Jun 2020 06:48:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726416AbgFLNrS (ORCPT + 99 others); Fri, 12 Jun 2020 09:47:18 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:60163 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726257AbgFLNrS (ORCPT ); Fri, 12 Jun 2020 09:47:18 -0400 Received: from marcel-macbook.fritz.box (ip-109-41-64-170.web.vodafone.de [109.41.64.170]) by mail.holtmann.org (Postfix) with ESMTPSA id CB5B1CED03; Fri, 12 Jun 2020 15:57:06 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH v3 0/3] Support reading and setting default system parameters From: Marcel Holtmann In-Reply-To: <20200611020157.70230-1-alainm@chromium.org> Date: Fri, 12 Jun 2020 15:47:16 +0200 Cc: linux-bluetooth@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <17B2F033-19B2-463A-A8D1-B561A5F16AD6@holtmann.org> References: <20200611020157.70230-1-alainm@chromium.org> To: Alain Michaud X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Alain, > This series adds support for reading and setting default system > parameters from userspace. In particular, combined with the userspace > changes, allows platforms to override default system parameters from a > main.conf file. > > The series has been reviewed and tested on chromeos. > > > Changes in v3: > - Fixed sparse errors > -Fixing sparse errors > > Changes in v2: > - Renamed the mgmt.h per Marcel's comments. > - Addressed Marcel's comments in the implementation. > > Alain Michaud (3): > mgmt: read/set system parameter definitions > bluetooth:centralize default value initialization. > bluetooth: implement read/set default system parameters mgmt > > include/net/bluetooth/hci_core.h | 18 +++ > include/net/bluetooth/mgmt.h | 30 ++++ > net/bluetooth/Makefile | 2 +- > net/bluetooth/hci_conn.c | 14 +- > net/bluetooth/hci_core.c | 14 +- > net/bluetooth/hci_request.c | 15 +- > net/bluetooth/mgmt.c | 6 + > net/bluetooth/mgmt_config.c | 253 +++++++++++++++++++++++++++++++ > net/bluetooth/mgmt_config.h | 11 ++ > 9 files changed, 341 insertions(+), 22 deletions(-) > create mode 100644 net/bluetooth/mgmt_config.c > create mode 100644 net/bluetooth/mgmt_config.h all 3 patch have been applied with modifications to bluetooth-next tree. Regards Marcel