Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH] bluetooth: Fix op_code size entry from the previous patch
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20200612193358.203186-1-alainm@chromium.org>
Date:   Fri, 12 Jun 2020 21:42:09 +0200
Cc:     linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <FCDEE47E-B787-4B64-A57B-00EB213AE0CD@holtmann.org>
References: <20200612193358.203186-1-alainm@chromium.org>
To:     Alain Michaud <alainm@chromium.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Alain,

> The previous applied patch introduced an error that was not present in
> the submitted patch here: https://patchwork.kernel.org/patch/11599123/
> 
> In particular MGMT_SET_DEF_SYSTEM_CONFIG_SIZE was introduced but
> MGMT_SET_DEF_SYSTEM_CONFIG was used.
> 
> Signed-off-by: Alain Michaud <alainm@chromium.org>
> ---
> 
> net/bluetooth/mgmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 2e0f976e7e04..99fbfd467d04 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -7303,7 +7303,7 @@ static const struct hci_mgmt_handler mgmt_handlers[] = {
> 						HCI_MGMT_HDEV_OPTIONAL },
> 	{ read_def_system_config,  MGMT_READ_DEF_SYSTEM_CONFIG_SIZE,
> 						HCI_MGMT_UNTRUSTED },
> -	{ set_def_system_config,   MGMT_SET_DEF_SYSTEM_CONFIG,
> +	{ set_def_system_config,   MGMT_SET_DEF_SYSTEM_CONFIG_SIZE,
> 						HCI_MGMT_VAR_LEN },

This was me being stupid. I had this fixed up in my tree, but forgot to amend the commit. I force pushed a correct commit to bluetooth-next now.

Regards

Marcel