Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Szymon Janc <szymon.janc@codecoup.pl>
To:     linux-bluetooth@vger.kernel.org,
        Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
        Pali =?ISO-8859-1?Q?Roh=E1r?= <pali@kernel.org>
Subject: Re: [PATCH] sap: Improve error messages
Date:   Mon, 15 Jun 2020 11:48:20 +0200
Message-ID: <4237143.LvFx2qVVIh@ix>
Organization: CODECOUP
In-Reply-To: <20200604232433.4951-1-pali@kernel.org>
References: <20200604232433.4951-1-pali@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi,

On Friday, 5 June 2020 01:24:33 CEST Pali Roh=E1r wrote:
> When bluetoohd daemon is starting, it prints following error messages:
>=20
> bluetoothd[19117]: profiles/sap/server.c:sap_server_register() Sap driver
> initialization failed. bluetoothd[19117]: sap-server: Operation not
> permitted (1)
>=20
> Initialization is failing because sap server is enabled only when
> bluetoothd daemon is started with --experimental option.
>=20
> And "Operation not permitted" is result of returning error code -1.
>=20
> This patch improves error messages. When --experimental option is not used
> then bluetoothd prints more explaining error message. And in case function
> sap_init() fails then -EOPNOTSUPP "Operation not supported" is returned
> instead of -EPERM (-1).
> ---
>  profiles/sap/server.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/profiles/sap/server.c b/profiles/sap/server.c
> index 5de682a33..99ff80297 100644
> --- a/profiles/sap/server.c
> +++ b/profiles/sap/server.c
> @@ -1353,9 +1353,14 @@ int sap_server_register(struct btd_adapter *adapte=
r)
>  	GIOChannel *io;
>  	struct sap_server *server;
>=20
> +	if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL)) {
> +		error("Sap driver is disabled without --experimental=20
option");
> +		return -EOPNOTSUPP;
> +	}
> +

Maybe just make sap_init() fail if experimental is not enabled in sap-dummy=
=2Ec?

This driver is usable only for profile qualification tests and nothing more.
And TBH I'm not sure why distros are enabling SAP in first place...

>  	if (sap_init() < 0) {
>  		error("Sap driver initialization failed.");
> -		return -1;
> +		return -EOPNOTSUPP;
>  	}
>=20
>  	record =3D create_sap_record(SAP_SERVER_CHANNEL);


=2D-=20
pozdrawiam
Szymon Janc