Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5ee80e6a.1c69fb81.7796.7fac@mx.google.com>
Date:   Mon, 15 Jun 2020 17:12:26 -0700 (PDT)
Content-Type: multipart/mixed; boundary="===============7612047573608803163=="
MIME-Version: 1.0
From:   bluez.test.bot@gmail.com
To:     linux-bluetooth@vger.kernel.org, michaelfsun@google.com
Subject: RE: [bluez,v1,2/3] btmgmt: Add btmgmt command advmon-remove
Reply-To: linux-bluetooth@vger.kernel.org
In-Reply-To: <20200616000318.42664-3-michaelfsun@google.com>
References: <20200616000318.42664-3-michaelfsun@google.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

--===============7612047573608803163==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkpatch Failed

Outputs:
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'advmon_removed', this function's name, in a string
#32: FILE: tools/btmgmt.c:1022:
+		error("Too small (%u bytes) advmon_removed event", len);

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'advmon_removed', this function's name, in a string
#36: FILE: tools/btmgmt.c:1026:
+	print("hci%u advmon_removed: handle %u", index, ev->monitor_handle);

WARNING:SSCANF_TO_KSTRTO: Prefer kstrto<type> to single variable sscanf
#71: FILE: tools/btmgmt.c:4686:
+	if (sscanf(argv[1], "%hx", &monitor_handle) != 1) {
+		error("Wrong formatted handle argument");
+		return bt_shell_noninteractive_quit(EXIT_FAILURE);
+	}

- total: 0 errors, 3 warnings, 79 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


---
Regards,
Linux Bluetooth

--===============7612047573608803163==--