Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5ee80e6b.1c69fb81.8ff3e.42c8@mx.google.com>
Date:   Mon, 15 Jun 2020 17:12:27 -0700 (PDT)
Content-Type: multipart/mixed; boundary="===============1251069115927506470=="
MIME-Version: 1.0
From:   bluez.test.bot@gmail.com
To:     linux-bluetooth@vger.kernel.org, michaelfsun@google.com
Subject: RE: [bluez,v1,3/3] btmgmt: Add btmgmt command advmon-add
Reply-To: linux-bluetooth@vger.kernel.org
In-Reply-To: <20200616000318.42664-4-michaelfsun@google.com>
References: <20200616000318.42664-4-michaelfsun@google.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

--===============1251069115927506470==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkpatch Failed

Outputs:
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'advmon_added', this function's name, in a string
#38: FILE: tools/btmgmt.c:1026:
+	print("hci%u advmon_added: handle %u", index, ev->monitor_handle);

WARNING:NAKED_SSCANF: unchecked sscanf return value
#84: FILE: tools/btmgmt.c:4710:
+		if (!sscanf(&pattern_str[i++], "%2hhx", &pattern->value[j]))
+			return false;

WARNING:NAKED_SSCANF: unchecked sscanf return value
#86: FILE: tools/btmgmt.c:4712:
+		if (i < str_len && !sscanf(&pattern_str[i], "%1hhx", &tmp))
+			return false;

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#107: FILE: tools/btmgmt.c:4733:
+static struct option advmon_add_options[] =
+					{ { "help", 0, 0, 'h' },

WARNING:LONG_LINE: line over 80 characters
#145: FILE: tools/btmgmt.c:4771:
+				sizeof(struct mgmt_cp_add_adv_patterns_monitor) +

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#158: FILE: tools/btmgmt.c:4784:
+			/* fall through */

- total: 1 errors, 5 warnings, 182 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


---
Regards,
Linux Bluetooth

--===============1251069115927506470==--