Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200615212806.BlueZ.v1.1.I8328c620402620c9aadc149614bb279e42a9db4f@changeid>
In-Reply-To: <20200615212806.BlueZ.v1.1.I8328c620402620c9aadc149614bb279e42a9db4f@changeid>
From:   "Von Dentz, Luiz" <luiz.von.dentz@intel.com>
Date:   Mon, 15 Jun 2020 23:14:49 -0700
Message-ID: <CACumGOJuBW+F9KsFJrtFCTErQj8u6jrR+3rTi8t4xuG6ow7gsQ@mail.gmail.com>
Subject: Re: [BlueZ PATCH v1] lib: Correct the name of Add Advertisement
 Patterns Monitor Command opcode
To:     Miao-chen Chou <mcchou@chromium.org>
Cc:     Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>,
        Alain Michaud <alainm@chromium.org>,
        Marcel Holtmann <marcel@holtmann.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Miao,

On Mon, Jun 15, 2020 at 9:28 PM Miao-chen Chou <mcchou@chromium.org> wrote:
>
>  lib/mgmt.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/mgmt.h b/lib/mgmt.h
> index f44f2465d..bb31156ab 100644
> --- a/lib/mgmt.h
> +++ b/lib/mgmt.h
> @@ -673,7 +673,7 @@ struct mgmt_adv_pattern {
>         uint8_t value[31];
>  } __packed;
>
> -#define MGMT_OP_ADD_ADV_MONITOR                        0x0052
> +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR       0x0052
>  struct mgmt_cp_add_adv_monitor {
>         uint8_t pattern_count;
>         struct mgmt_adv_pattern patterns[0];
> --
> 2.26.2


The name already contains PATTERNS:

https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc/mgmt-api.txt#n3499