Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp388646ybt; Wed, 17 Jun 2020 03:44:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwAyX+DZeOGfHNYyxOC092ooP5kQuK3awswhUY7sF/schVR72mYl8j6tfB1+PVtHP5+2Nr X-Received: by 2002:a17:907:441c:: with SMTP id om20mr6518775ejb.62.1592390694768; Wed, 17 Jun 2020 03:44:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592390694; cv=none; d=google.com; s=arc-20160816; b=kHt8wVxU2TVCDUpxEsfBleYR3tkBFHSL/vL7I1b/WP6Y0x7jYVYmR0ZBBEy5Y6CnAQ YiMYvkD92Pu+NsStTO9TTVvfYrIvJPbMTiYz3XCVzMFlobwuAIcsQcoISS8QpBk5iMbQ cNkQBNjgFYmoZ+1KiLmrcs9m0PF89tP3oExNOfK5duN+kquLsXUyuHNW7ZDYSJ0CF1/J d+WrWGthXAkNXXMUKtmtD1KaotsN0CGO6kwgFHuf39/zE0eU4BEzmI1pHqZ2hrjvBR8/ 6qErCshaTO2cIahYu2uGpWQ7wA1ci9qXTLlX2Wyv/oVOqLcDPJl90K5BIZ6jaL9nCjZt 6Vkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=FkY5RlDzBfU8hAZykkWDfEOiD6kBdEe//gtq9Ga7tSE=; b=sSQwXNO0rwJ/k8ixTAUnDfObozWmOsDDlkUVQq0XHrI33XW9BanVtKWKPmD2SzBRTc lBbK5DeNzJX2R1uB8OqsLUG78gB90Dp6MhiJKqHOCJICVDgiDaQStRkAL2irBdG/kCbm Unc7uHv8c3DU2TOoupiUGfYkc5g4nVtXW9fWPBDCpYELgVF8I6VRm+pA6xZFalTj9N21 BGDG7RxDtJfaIGhyEfv5z6dHln3vBnb3lroF03uUB/L0/sw5cnkhLoUlFMZpvPlshNvu Ya6X8M7IpZwevTzNp1pckZaKIR6qq886GrFIB6Pd2TC5TR7vTWtRQWuebvw+aRg4923h NHZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o10si13522114ejr.656.2020.06.17.03.44.31; Wed, 17 Jun 2020 03:44:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726594AbgFQKmR (ORCPT + 99 others); Wed, 17 Jun 2020 06:42:17 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:42083 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726642AbgFQKmN (ORCPT ); Wed, 17 Jun 2020 06:42:13 -0400 Received: from localhost.localdomain (p5b3d2638.dip0.t-ipconnect.de [91.61.38.56]) by mail.holtmann.org (Postfix) with ESMTPSA id 6E456CECD3 for ; Wed, 17 Jun 2020 12:52:03 +0200 (CEST) From: Marcel Holtmann To: linux-bluetooth@vger.kernel.org Subject: [PATCH 14/14] Bluetooth: mgmt: Use command complete on success for set system config Date: Wed, 17 Jun 2020 12:42:05 +0200 Message-Id: X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org The command status reply is only for failure. When completing set system config command, the reply has to be command complete. Signed-off-by: Marcel Holtmann --- net/bluetooth/mgmt_config.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/bluetooth/mgmt_config.c b/net/bluetooth/mgmt_config.c index 8e7ad2a51dbb..8d01a8ff85e9 100644 --- a/net/bluetooth/mgmt_config.c +++ b/net/bluetooth/mgmt_config.c @@ -247,9 +247,8 @@ int set_def_system_config(struct sock *sk, struct hci_dev *hdev, void *data, buffer += exp_len; } - return mgmt_cmd_status(sk, hdev->id, - MGMT_OP_SET_DEF_SYSTEM_CONFIG, - MGMT_STATUS_SUCCESS); + return mgmt_cmd_complete(sk, hdev->id, + MGMT_OP_SET_DEF_SYSTEM_CONFIG, 0, NULL, 0); } int read_def_runtime_config(struct sock *sk, struct hci_dev *hdev, void *data, -- 2.26.2