Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1592390407.git.marcel@holtmann.org> <dd2310913558d6c63e193ea111ef2681e5911837.1592390407.git.marcel@holtmann.org>
In-Reply-To: <dd2310913558d6c63e193ea111ef2681e5911837.1592390407.git.marcel@holtmann.org>
From:   Alain Michaud <alainmichaud@google.com>
Date:   Wed, 17 Jun 2020 08:50:36 -0400
Message-ID: <CALWDO_Vz2LiAW338=bo+kj0z+tLeA4vf3an-hdYwdVrSAOkDVA@mail.gmail.com>
Subject: Re: [PATCH 14/14] Bluetooth: mgmt: Use command complete on success
 for set system config
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     BlueZ <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel,


On Wed, Jun 17, 2020 at 6:43 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> The command status reply is only for failure. When completing set system
> config command, the reply has to be command complete.
>
Reviewed-by: Alain Michaud <alainm@chromium.org>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  net/bluetooth/mgmt_config.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/net/bluetooth/mgmt_config.c b/net/bluetooth/mgmt_config.c
> index 8e7ad2a51dbb..8d01a8ff85e9 100644
> --- a/net/bluetooth/mgmt_config.c
> +++ b/net/bluetooth/mgmt_config.c
> @@ -247,9 +247,8 @@ int set_def_system_config(struct sock *sk, struct hci_dev *hdev, void *data,
>                 buffer += exp_len;
>         }
>
> -       return mgmt_cmd_status(sk, hdev->id,
> -                              MGMT_OP_SET_DEF_SYSTEM_CONFIG,
> -                              MGMT_STATUS_SUCCESS);
> +       return mgmt_cmd_complete(sk, hdev->id,
> +                                MGMT_OP_SET_DEF_SYSTEM_CONFIG, 0, NULL, 0);
>  }
>
>  int read_def_runtime_config(struct sock *sk, struct hci_dev *hdev, void *data,
> --
> 2.26.2
>

Thanks,
Alain