Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp543101ybt; Wed, 17 Jun 2020 07:43:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO996f6RnuJc/Inx2bU5/SL2wMH+y/oLn4Yyz5RyswkJ8VmvdkyZFYUry1Xbtm9rMJJR3/ X-Received: by 2002:a17:906:fac8:: with SMTP id lu8mr7582663ejb.432.1592405025847; Wed, 17 Jun 2020 07:43:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592405025; cv=none; d=google.com; s=arc-20160816; b=g4PgJz0MZOtB6ru0ymAqHeBwioPo+5Z5c8Ci5cRHeX5g1rxBU410CQxO8o2HDVgH47 5hPEgVosgxNm6Ux3fLo3nP3Rr0Ia0PYzNHfuwPU76Sg9xGBPF02L+5uDv6RVQaAigqT+ DZ+l/SrNd2CtAqAet3R0Ar0SgMcoq5M99c4JUPCCgzYgwXBUckvQaKe19KQo8rnPr3t3 mKkLbdH1qVGbTHGcF88m/HZzl77tjCuPRAqz3qwLoiDlUsj6z8I7IpsxduesEaokTliq BszVIxOXSF+1XJHpHfzmsNunl2Z1Qqso/bWEbY/1wWhIjGNNFSM6NjEnQVNmBf72AusM 105A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=W1J271kWKU0lvyHfmC1jxHrcqC2xPmpcjAkrZCExepg=; b=e0sLG/+aRRn+8MpvKXaB7q+InccoTq2ubfP8pOcRQ7ADK87ISbp53oClNlRkDYJRZR DxugVYf0tqmWEzvqBhO54HTyOm7yXo11WqKr3DYY0YxsSjl5Wmnw3DZJFkvUQl1SeKal jN7h+TW1JTyOlvSUJBCk1paoW41OMyuQeY1338lQhjqbYC9iwdcNn9jxza63oLiJTuBH etwOznPP/EtZm5Kczdp87sotg//9CwBrGH1G/spIwFjfOuYdFasEy9QNVFwiHdiYh5HH hchUWqpF2qklF1E8MoFtUicSkh/fv34ZGveF/MIXY5aaey4k8bg5BVnTn2tp+GuzSE7R Q+gw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q5si65979edw.228.2020.06.17.07.43.22; Wed, 17 Jun 2020 07:43:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726999AbgFQOjb (ORCPT + 99 others); Wed, 17 Jun 2020 10:39:31 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:49147 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727055AbgFQOja (ORCPT ); Wed, 17 Jun 2020 10:39:30 -0400 Received: from localhost.localdomain (p5b3d2638.dip0.t-ipconnect.de [91.61.38.56]) by mail.holtmann.org (Postfix) with ESMTPSA id E7F95CECE3 for ; Wed, 17 Jun 2020 16:49:17 +0200 (CEST) From: Marcel Holtmann To: linux-bluetooth@vger.kernel.org Subject: [PATCH v2 14/14] Bluetooth: mgmt: Use command complete on success for set system config Date: Wed, 17 Jun 2020 16:39:20 +0200 Message-Id: <13f017e592c175aa4af83f09521305da3c7edd74.1592404644.git.marcel@holtmann.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org The command status reply is only for failure. When completing set system config command, the reply has to be command complete. Signed-off-by: Marcel Holtmann Reviewed-by: Alain Michaud --- net/bluetooth/mgmt_config.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/bluetooth/mgmt_config.c b/net/bluetooth/mgmt_config.c index 8e7ad2a51dbb..8d01a8ff85e9 100644 --- a/net/bluetooth/mgmt_config.c +++ b/net/bluetooth/mgmt_config.c @@ -247,9 +247,8 @@ int set_def_system_config(struct sock *sk, struct hci_dev *hdev, void *data, buffer += exp_len; } - return mgmt_cmd_status(sk, hdev->id, - MGMT_OP_SET_DEF_SYSTEM_CONFIG, - MGMT_STATUS_SUCCESS); + return mgmt_cmd_complete(sk, hdev->id, + MGMT_OP_SET_DEF_SYSTEM_CONFIG, 0, NULL, 0); } int read_def_runtime_config(struct sock *sk, struct hci_dev *hdev, void *data, -- 2.26.2