Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH v3] Bluetooth: use configured params for ext adv
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20200622133028.26882-1-alainm@chromium.org>
Date:   Mon, 22 Jun 2020 16:04:28 +0200
Cc:     BlueZ <linux-bluetooth@vger.kernel.org>,
        Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
        Daniel Winkler <danielwinkler@google.com>
Content-Transfer-Encoding: 8BIT
Message-Id: <796C3F6A-D9E9-4C20-A9BC-5DB53E2A21C4@holtmann.org>
References: <20200622133028.26882-1-alainm@chromium.org>
To:     Alain Michaud <alainm@chromium.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Alain,

> When the extended advertisement feature is enabled, a hardcoded min and
> max interval of 0x8000 is used.  This patch fixes this issue by using
> the configured min/max value.
> 
> This was validated by setting min/max in main.conf and making sure the
> right setting is applied:
> 
> < HCI Command: LE Set Extended Advertising Parameters (0x08|0x0036) plen
> 25                                          #93 [hci0] 10.953011
> …
> Min advertising interval: 181.250 msec (0x0122)
> Max advertising interval: 181.250 msec (0x0122)
> …
> 
> Signed-off-by: Alain Michaud <alainm@chromium.org>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> Reviewed-by: Daniel Winkler <danielwinkler@google.com>
> 
> ---
> 
> Changes in v3:
> -adding 3 octet comment back per Marcel's suggestion
> 
> Changes in v2:
> -fix commit title and typo in description.
> -Moved le24 convertion to  hci_cpu_to_le24
> 
> include/net/bluetooth/hci.h | 8 ++++++++
> net/bluetooth/hci_request.c | 7 +++----
> 2 files changed, 11 insertions(+), 4 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel