Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200619155612.bluez.v4.2.Ib8ae2d78936aa9f16a318aca14cf8c7198449bac@changeid>
 <5eed44b6.1c69fb81.44ef1.7e06@mx.google.com>
In-Reply-To: <5eed44b6.1c69fb81.44ef1.7e06@mx.google.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 22 Jun 2020 09:57:03 -0700
Message-ID: <CABBYNZKWN5G0qfnpirOZddEuHJtdYpzPDMJGJKpns3gXD3G9EQ@mail.gmail.com>
Subject: Re: [bluez,v4,2/3] btmgmt: Add command "remove" into "monitor" btmgmt submenu
To:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Cc:     Michael Sun <michaelfsun@google.com>,
        Tedd Ho-Jeong An <tedd.an@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Tedd,

On Fri, Jun 19, 2020 at 9:57 PM <bluez.test.bot@gmail.com> wrote:
>
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> While we are preparing for reviewing the patches, we found the following
> issue/warning.
>
> Test Result:
> checkpatch Failed
>
> Outputs:
> WARNING:SSCANF_TO_KSTRTO: Prefer kstrto<type> to single variable sscanf
> #78: FILE: tools/btmgmt.c:4686:
> +       if (sscanf(argv[1], "%hx", &monitor_handle) != 1) {
> +               error("Wrong formatted handle argument");
> +               return bt_shell_noninteractive_quit(EXIT_FAILURE);
> +       }

We might want to turn off this warning since it doesn't apply to
userspace where kstrto is not available.

> - total: 0 errors, 1 warnings, 80 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> Your patch has style problems, please review.
>
> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
>
> ---
> Regards,
> Linux Bluetooth


-- 
Luiz Augusto von Dentz