Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: +jKSF22dC1WzbYeY6AO5Wurkii6Z+OauhklVS/7rtB059P4ClIyVFYy82D8sFny3Oj3AEEhGS6
 l+bDqwcR2qCA==
IronPort-SDR: v4f9kSERP0A6Lh5riOtLtL+jF8FmGNpQK/f8SxR244QL8Gfpk6/zyeZNJURtJk5d5QbVErdDh8
 /hybQIkB+m5Q==
Message-ID: <2db64e58e9aca20f4203ae3e34d5f12543a65afa.camel@linux.intel.com>
Subject: Re: [bluez,v4,2/3] btmgmt: Add command "remove" into "monitor"
 btmgmt submenu
From:   Tedd Ho-Jeong An <tedd.an@linux.intel.com>
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Date:   Mon, 22 Jun 2020 10:28:36 -0700
In-Reply-To: <CABBYNZKWN5G0qfnpirOZddEuHJtdYpzPDMJGJKpns3gXD3G9EQ@mail.gmail.com>
References: <20200619155612.bluez.v4.2.Ib8ae2d78936aa9f16a318aca14cf8c7198449bac@changeid>
         <5eed44b6.1c69fb81.44ef1.7e06@mx.google.com>
         <CABBYNZKWN5G0qfnpirOZddEuHJtdYpzPDMJGJKpns3gXD3G9EQ@mail.gmail.com>
Organization: Intel Corporation
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Luiz,

On Mon, 2020-06-22 at 09:57 -0700, Luiz Augusto von Dentz wrote:
> Hi Tedd,
> 
> On Fri, Jun 19, 2020 at 9:57 PM <bluez.test.bot@gmail.com> wrote:
> > 
> > This is automated email and please do not reply to this email!
> > 
> > Dear submitter,
> > 
> > Thank you for submitting the patches to the linux bluetooth mailing list.
> > While we are preparing for reviewing the patches, we found the following
> > issue/warning.
> > 
> > Test Result:
> > checkpatch Failed
> > 
> > Outputs:
> > WARNING:SSCANF_TO_KSTRTO: Prefer kstrto<type> to single variable sscanf
> > #78: FILE: tools/btmgmt.c:4686:
> > +       if (sscanf(argv[1], "%hx", &monitor_handle) != 1) {
> > +               error("Wrong formatted handle argument");
> > +               return bt_shell_noninteractive_quit(EXIT_FAILURE);
> > +       }
> 
> We might want to turn off this warning since it doesn't apply to
> userspace where kstrto is not available.

I made a change.
Also, I submit the patch to add .checkpatch.conf in the tree which will also
help others to run checkpatch before submissing.

Once it is checked in, I will update the CI.

> 
> > - total: 0 errors, 1 warnings, 80 lines checked
> > 
> > NOTE: For some of the reported defects, checkpatch may be able to
> >       mechanically convert to the typical style using --fix or --fix-
> > inplace.
> > 
> > Your patch has style problems, please review.
> > 
> > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT
> > FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING
> > 
> > NOTE: If any of the errors are false positives, please report
> >       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> > 
> > 
> > 
> > ---
> > Regards,
> > Linux Bluetooth
> 
> 
Regards,
Tedd Ho-Jeong An