Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3565432ybt; Tue, 23 Jun 2020 05:39:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzStKNJTYmX2FpamaqEe0ynMt6lY1HN+ebpoxR3Sd/PGkUIIC8/AAyfUdgb57YUPvzR+t0H X-Received: by 2002:a17:907:7283:: with SMTP id dt3mr20688997ejc.195.1592915940086; Tue, 23 Jun 2020 05:39:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592915940; cv=none; d=google.com; s=arc-20160816; b=X1NV5s07kMYrlMHe48mZTOp6EY2Zc4TkIsZxVrcmHFPt8yLbUaFILIUn+0fT7kQ6bQ deVw3SwicIS8kn6XfXg4yVn529bx2xZPF5Y1yfHOC5GebHCdQBaHTlQ5JBafSPsP5JIH cdNtaIpX3bhPGqRSJPjxv2jcl3raXbOxxnXELh4FVXwzJr62EpXOgee3j1nxA1MLpeNR eFBOXoTibT6G2HSW1DXvvHdEPxPCZaR7yXEsP4oNANLo/TeoFhVhf7tl308p22TYJk2a xk5Vi38gAU1BR7wC/z2rTse/3tKRmOeXUAnigmtJWtrA4+Et2GmHVxmUGjJsLLlFYWt3 E7Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=uMBHhzHYR2JDuQOqQNeTS9tyCnRmnElzJFpwQpHCYKA=; b=LR0NgPIFTrODa6lDBLJ5yM7lUf4dRHaiU7e/aA7kEMCtlzJbsVg/+6Gz9l2kBcBU/L /f4An9rIUzIGia6795pmiUf2qUja0eOw/mXHJTR5uqIfG4E0xuB/avTkyUvlJU9jK309 3gOEflIw4nDm3Y4YRH3s2bfi6Pb+aX14wPG2cxoDDZftf41pmoJ8T8ly5w5jr5/Xc76u ziMYBjZEuSqR05brdoTrpjqvqgfKcHJ6vPKN67IIpBdK9sIlKrQb0Q2+Rz6f4yBOwpF9 nhqzJ10Pbx6TFB0hnxDN50AGQ9bN+g8rCimzNzqBQlnI0ydEkqrq7CSlQ0I0isUE33DP Hp1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y17si5818462ejk.677.2020.06.23.05.38.34; Tue, 23 Jun 2020 05:39:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729611AbgFWMi2 convert rfc822-to-8bit (ORCPT + 99 others); Tue, 23 Jun 2020 08:38:28 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:44271 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729574AbgFWMi2 (ORCPT ); Tue, 23 Jun 2020 08:38:28 -0400 Received: from marcel-macpro.fritz.box (p5b3d2638.dip0.t-ipconnect.de [91.61.38.56]) by mail.holtmann.org (Postfix) with ESMTPSA id 9B9B6CECC3; Tue, 23 Jun 2020 14:48:19 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH v2 1/2] Bluetooth: btusb: fix up firmware download sequence From: Marcel Holtmann In-Reply-To: <1592850527-20931-1-git-send-email-sean.wang@mediatek.com> Date: Tue, 23 Jun 2020 14:38:26 +0200 Cc: Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Mark-YW.Chen@mediatek.com Content-Transfer-Encoding: 8BIT Message-Id: References: <5F6C2EB2-B0DF-4534-A123-4E6969A98410@holtmann.org> <1592850527-20931-1-git-send-email-sean.wang@mediatek.com> To: Sean Wang X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Sean, >>> Data RAM on the device have to be powered on before starting to >>> download the firmware. >>> >>> v1->v2: >>> rebased to bluetooth-next >>> >>> Fixes: a1c49c434e15 ("Bluetooth: btusb: Add protocol support for >>> MediaTek MT7668U USB devices") >>> Co-developed-by: Mark Chen >>> Signed-off-by: Mark Chen >>> Signed-off-by: Sean Wang >>> --- >>> drivers/bluetooth/btusb.c | 16 +++++++++++++++- >>> 1 file changed, 15 insertions(+), 1 deletion(-) >> >> something is fishy here. git am still fails. >> > > a little weird. I will try to git format-patch and send the patch again with another machine to you. I think it is more important that you use git send-email to ensure that patch is delivered correctly. It looks like it got base64 encoded for no reason. Regards Marcel