Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200603171713.9882-1-sathish.narasimman@intel.com> <ACE20ACA-6CE3-4348-88E2-D38DF6680C7F@holtmann.org>
In-Reply-To: <ACE20ACA-6CE3-4348-88E2-D38DF6680C7F@holtmann.org>
From:   Sathish Narasimman <nsathish41@gmail.com>
Date:   Wed, 1 Jul 2020 15:32:10 +0530
Message-ID: <CAOVXEJKYiTAwyRAwTinZsVu2PaP-yURcSzZJY=Hrs33xifyYGw@mail.gmail.com>
Subject: Re: [PATCH v2 0/7] LL Privacy support
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>,
        Sathish Narasimman <sathish.narasimman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel

On Fri, Jun 19, 2020 at 1:28 PM Marcel Holtmann <marcel@holtmann.org> wrote=
:
>
> Hi Sathish,
>
> > Based on the input the patches modified and verifed accordingly.
> >
> > Marcel Holtmann (3):
> >  Bluetooth: Translate additional address type correctly
> >  Bluetooth: Configure controller address resolution if available
> >  Bluetooth: Update resolving list when updating whitelist
> >
> > Sathish Narasimman (4):
> >  Bluetooth: Translate additional address type during le_conn
> >  Bluetooth: Let controller creates RPA during le create conn
> >  Bluetooth: Enable/Disable address resolution during le create conn
> >  Bluetooth: Enable RPA Timeout
> >
> > include/net/bluetooth/hci.h      |   8 ++-
> > include/net/bluetooth/hci_core.h |   3 +
> > net/bluetooth/hci_conn.c         |   6 +-
> > net/bluetooth/hci_core.c         |  17 +++++
> > net/bluetooth/hci_event.c        |  20 ++++++
> > net/bluetooth/hci_request.c      | 119 ++++++++++++++++++++++++++-----
> > net/bluetooth/hci_request.h      |   3 +-
> > net/bluetooth/mgmt.c             |   2 +-
> > 8 files changed, 157 insertions(+), 21 deletions(-)
>
> can you please rebase this against the latest bluetooth-next tree. With t=
he introduction of the advertising monitor, we now have a few conflicts tha=
t you need to resolve.
>
> Also as discussed, we wanted to hide this initially after an experimental=
 feature flag so it would need to be enabled first. And I think once enable=
d, we need to take the support of =E2=80=9Cadvertising=E2=80=9D aka periphe=
ral away from the controller until we can fully ensure it works for scannin=
g and advertising at the same time.

Updated the v3  rebased and the flag is introduced to enable LL
privacy from the host using mgmt set_privacy interface.

what I understood regarding removing of advertising was when we enable
LL privacy using mgmt interface. the advertisement should not work
(correct me please).

>
> Regards
>
> Marcel
>

Regards
Sathish N