Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: TdWHlBp//X+yXbhPyvjtBYEUldZ0/t5UYGEbPGeA63TyljAfSghAqCNKFvW/JEXhOdGD/irLbD
 TgZmDKHjU+Zw==
IronPort-SDR: CRaXBcYpNSNnzALPYcDthxnoGUuqbnzsQ5mEbBVEz7t3/N+9GqF7JVgT/vwX/t2ckW1Mq/k+Km
 gzAcGy4Qx16w==
From:   "K, Kiran" <kiran.k@intel.com>
To:     Marcel Holtmann <marcel@holtmann.org>
CC:     linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
        "Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>,
        "kiraank@gmail.com" <kiraank@gmail.com>,
        "Bag, Amit K" <amit.k.bag@intel.com>,
        Raghuram Hegde <raghuram.hegde@intel.com>
Subject: RE: [PATCH 2/5] Bluetooth: btintel: Refactor firmware header download
 sequence
Thread-Topic: [PATCH 2/5] Bluetooth: btintel: Refactor firmware header
 download sequence
Thread-Index: AQHWUGikJG8ZDOrkEUGU3i8Ku3Xo3Kj0R9GAgAA+jQA=
Date:   Thu, 2 Jul 2020 17:12:23 +0000
Message-ID: <BYAPR11MB3141F7C82AA1D4A78A8A1AC2F56D0@BYAPR11MB3141.namprd11.prod.outlook.com>
References: <20200702120315.26768-1-kiran.k@intel.com>
 <20200702120315.26768-3-kiran.k@intel.com>
 <8040CBA1-AF50-43A1-8314-4E44E4F27173@holtmann.org>
In-Reply-To: <8040CBA1-AF50-43A1-8314-4E44E4F27173@holtmann.org>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a4503c5-651c-4fd5-a2be-08d81eab162c
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 17:12:23.1061
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1uT0wECCpVtHWiJxt8wlA+fqe5yLNE9npw4K7AUHr6TQVXS/DReA/TSo5HbbG9uGs2Aycov2KRP6vIDfkEpfwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3656
X-OriginatorOrg: intel.com
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Marcel,

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org <linux-bluetooth-
> owner@vger.kernel.org> On Behalf Of Marcel Holtmann
> Sent: Thursday, July 2, 2020 6:56 PM
> To: K, Kiran <kiran.k@intel.com>
> Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>; Srivatsa, Ravishan=
kar
> <ravishankar.srivatsa@intel.com>; Tumkur Narayan, Chethan
> <chethan.tumkur.narayan@intel.com>; kiraank@gmail.com; Bag, Amit K
> <amit.k.bag@intel.com>; Raghuram Hegde <raghuram.hegde@intel.com>
> Subject: Re: [PATCH 2/5] Bluetooth: btintel: Refactor firmware header
> download sequence
>=20
> Hi Kiran,
>=20
> > Move firmware header download code to a separate function to enhance
> > readability and reusability
> >
> > Signed-off-by: Kiran K <kiran.k@intel.com>
> > Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
> > Signed-off-by: Raghuram Hegde <raghuram.hegde@intel.com>
> > Reviewed-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> > Reviewed-by: Sathish Narasimman <Sathish.Narasimman@intel.com>
> > Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@intel.com>
> > ---
> > drivers/bluetooth/btintel.c | 21 +++++++++++++++++----
> > 1 file changed, 17 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> > index dea96c585ecb..1c820c187421 100644
> > --- a/drivers/bluetooth/btintel.c
> > +++ b/drivers/bluetooth/btintel.c
> > @@ -646,12 +646,10 @@ int btintel_read_boot_params(struct hci_dev
> > *hdev, } EXPORT_SYMBOL_GPL(btintel_read_boot_params);
> >
> > -int btintel_download_firmware(struct hci_dev *hdev, const struct firmw=
are
> *fw,
> > -			      u32 *boot_param)
> > +static int btintel_sfi_rsa_header_secure_send(struct hci_dev *hdev,
> > +					      const struct firmware *fw)
> > {
> > 	int err;
> > -	const u8 *fw_ptr;
> > -	u32 frag_len;
> >
> > 	/* Start the firmware download transaction with the Init fragment
> > 	 * represented by the 128 bytes of CSS header.
> > @@ -679,6 +677,21 @@ int btintel_download_firmware(struct hci_dev
> *hdev, const struct firmware *fw,
> > 		bt_dev_err(hdev, "Failed to send firmware signature (%d)",
> err);
> > 		goto done;
> > 	}
>=20
> Here should be an extra empty line before the label.

Ack. I will fix it in v2.
>=20
> > +done:
> > +	return err;
> > +}
> > +
> > +int btintel_download_firmware(struct hci_dev *hdev, const struct firmw=
are
> *fw,
> > +			      u32 *boot_param)
> > +{
> > +	int err;
> > +	const u8 *fw_ptr;
> > +	u32 frag_len;
> > +
> > +	err =3D btintel_sfi_rsa_header_secure_send(hdev, fw);
> > +	if (err)
> > +		goto done;
> > +
>=20
> Scrap the extra empty line here.

Ack.
>=20
> >
> > 	fw_ptr =3D fw->data + 644;
> > 	frag_len =3D 0;
>=20
> Regards
>=20
> Marcel

Thanks,
Kiran