Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] Bluetooth: btusb: Fix and detect most of the Chinese
 Bluetooth controllers
From:   Swyter <swyterzone@gmail.com>
To:     BlueZ <linux-bluetooth@vger.kernel.org>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>
References: <6bce2c08-48f0-f49c-d70c-280475220550@gmail.com>
Message-ID: <1bff6e62-1815-ffe7-a06e-8e303b717e46@gmail.com>
Date:   Sun, 5 Jul 2020 22:54:57 +0200
User-Agent: nano 6.4
MIME-Version: 1.0
In-Reply-To: <6bce2c08-48f0-f49c-d70c-280475220550@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On 05/07/2020 21:21, Ismael Ferreras Morezuelas wrote:
> @@ -4001,11 +4053,13 @@ static int btusb_probe(struct usb_interface *intf,
>  		if (bcdDevice < 0x117)
>  			set_bit(HCI_QUIRK_RESET_ON_CLOSE, &hdev->quirks);
>  
> +		/* This must be set first in case we disable it for fakes */
> +		set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);
> +
>  		/* Fake CSR devices with broken commands */
> -		if (bcdDevice <= 0x100 || bcdDevice == 0x134)
> +		if (udev->descriptor.idVendor  == 0x0a12 &&
> +		    udev->descriptor.idProduct == 0x0001)
>  			hdev->setup = btusb_setup_csr;

Noticed that I'm probably missing a few le16_to_cpu() there,
from what I've seen in other places. I'll keep it in mind.

Self-review. :)