Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH BlueZ] Add a presubmit configuration file for Chromium OS
 repo
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20200717231404.240644-1-sonnysasaka@chromium.org>
Date:   Tue, 28 Jul 2020 09:14:09 +0200
Cc:     linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <8E0368F4-1F53-403B-8EDC-51533108E54A@holtmann.org>
References: <20200717231404.240644-1-sonnysasaka@chromium.org>
To:     Sonny Sasaka <sonnysasaka@chromium.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Sonny,

> Chromium OS developers use gerrit and repo in their workflow.
> (https://gerrit.googlesource.com/git-repo/). This configuration file
> makes it easier when uploading patches to gerrit with the repo tool.
> 
> ---
> PRESUBMIT.cfg | 8 ++++++++
> 1 file changed, 8 insertions(+)
> create mode 100644 PRESUBMIT.cfg
> 
> diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg
> new file mode 100644
> index 000000000..10f89b741
> --- /dev/null
> +++ b/PRESUBMIT.cfg
> @@ -0,0 +1,8 @@
> +# This is a configuration for Chromium OS repo pre-upload hooks.
> +# repohooks doc: https://chromium.googlesource.com/chromiumos/repohooks/
> +# Chromium OS BlueZ git repo: https://chromium.googlesource.com/chromiumos/third_party/bluez/
> +
> +[Hook Overrides]
> +cros_license_check: false
> +tab_check: false
> +checkpatch_check: true

I am not in favor of adding anything in the top-level directory that is not for for the BlueZ upstream usage.

Regards

Marcel