Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp2488897ybg; Fri, 31 Jul 2020 00:43:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1HjLNiMdFmI1jOlEIXaW0LT6JwOAigZaWTpa+7y3WD+dyPKmr/celJwAANCWk48rDmOGV X-Received: by 2002:a17:906:9984:: with SMTP id af4mr3000177ejc.90.1596181391840; Fri, 31 Jul 2020 00:43:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596181391; cv=none; d=google.com; s=arc-20160816; b=UKTbWrDaf95J/B5ZTpSy2ds889TwhiOdTxEvvT472dMgdhtmrxwR9CZn2v4WFcz3EC 5H/54RXuju+qmsGZoPC2tp8d4+oJb6QoEjX59bJ94P62vENc2atSdN3yDDKk/UOEIMCO ++f+jleurWb2xPcReH5lec6JH8fPiaZ0MQ0KdKZtObBCW3pgoipQ+pY6Xf9WzQwSBeH1 5ThBfHmp91xIxbEfDwuupbH46zEotg7LjYbcw4+0tTkvW98+XWFzk+h/jS/F0Url3808 YdxnfVovJ1ImgfbJ/ShQ1KkG5EmYE3OydLNYdjXtm8XmThNDIANH/V2QrPVzBPp8ORjO MUxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date; bh=PSA8L7BgdA7zDEUUjVitTkpf3tAIn4ELBicjRTSgplo=; b=SH7lif1M07U/35AZwnELDF/77uisTSa1tCy8nM2rXin+SIuAzN50KPFccNhsyjfd32 KjiOdDDdfUK9I9hdk6Px7mFbh3d8UMMTB6yDOKMtyM16QzmlW+4QsCUaimlKrdrWA6EJ l0/hf9th2ZlFK1oqpahj3YMEzJc/jNfAujupPpcGAid9Be1AZ2Cw9Pcy5E8BKm1PS+Mp fQuOP3dB3yjVRvttg/gozVKSIbFV4xWmGd1xE2hzrnYa+PQSmndCYuDZhNWeOzDfawEj tvaYb2v9P+YwRyDmfi9hue3Wt3r5HZvcevSQ29EYp0Ru4fCqq2yIGpkL2rZ3gOx8vcah aIzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lo6si4311791ejb.584.2020.07.31.00.42.30; Fri, 31 Jul 2020 00:43:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731574AbgGaHmI (ORCPT + 99 others); Fri, 31 Jul 2020 03:42:08 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:39910 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727851AbgGaHmI (ORCPT ); Fri, 31 Jul 2020 03:42:08 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1k1Pfy-0001TP-Sl; Fri, 31 Jul 2020 17:42:00 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 31 Jul 2020 17:41:58 +1000 Date: Fri, 31 Jul 2020 17:41:58 +1000 From: Herbert Xu To: Marcel Holtmann , Johan Hedberg , linux-bluetooth@vger.kernel.org Cc: Tudor Ambarus Subject: [PATCH] Bluetooth: Remove CRYPTO_ALG_INTERNAL flag Message-ID: <20200731074158.GA20263@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org The flag CRYPTO_ALG_INTERNAL is not meant to be used outside of the Crypto API. It isn't needed here anyway. Signed-off-by: Herbert Xu diff --git a/net/bluetooth/selftest.c b/net/bluetooth/selftest.c index 03e3c89c3046..f71c6fa65fb3 100644 --- a/net/bluetooth/selftest.c +++ b/net/bluetooth/selftest.c @@ -205,7 +205,7 @@ static int __init test_ecdh(void) calltime = ktime_get(); - tfm = crypto_alloc_kpp("ecdh", CRYPTO_ALG_INTERNAL, 0); + tfm = crypto_alloc_kpp("ecdh", 0, 0); if (IS_ERR(tfm)) { BT_ERR("Unable to create ECDH crypto context"); err = PTR_ERR(tfm); diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c index c2c5ab05fa7e..b0d7310b9d16 100644 --- a/net/bluetooth/smp.c +++ b/net/bluetooth/smp.c @@ -1387,7 +1387,7 @@ static struct smp_chan *smp_chan_create(struct l2cap_conn *conn) goto zfree_smp; } - smp->tfm_ecdh = crypto_alloc_kpp("ecdh", CRYPTO_ALG_INTERNAL, 0); + smp->tfm_ecdh = crypto_alloc_kpp("ecdh", 0, 0); if (IS_ERR(smp->tfm_ecdh)) { BT_ERR("Unable to create ECDH crypto context"); goto free_shash; @@ -3282,7 +3282,7 @@ static struct l2cap_chan *smp_add_cid(struct hci_dev *hdev, u16 cid) return ERR_CAST(tfm_cmac); } - tfm_ecdh = crypto_alloc_kpp("ecdh", CRYPTO_ALG_INTERNAL, 0); + tfm_ecdh = crypto_alloc_kpp("ecdh", 0, 0); if (IS_ERR(tfm_ecdh)) { BT_ERR("Unable to create ECDH crypto context"); crypto_free_shash(tfm_cmac); @@ -3847,7 +3847,7 @@ int __init bt_selftest_smp(void) return PTR_ERR(tfm_cmac); } - tfm_ecdh = crypto_alloc_kpp("ecdh", CRYPTO_ALG_INTERNAL, 0); + tfm_ecdh = crypto_alloc_kpp("ecdh", 0, 0); if (IS_ERR(tfm_ecdh)) { BT_ERR("Unable to create ECDH crypto context"); crypto_free_shash(tfm_cmac); -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt