Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2666139pxa; Mon, 17 Aug 2020 16:01:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3cy1VYOpSGj67pIyV9AdpjjuynL1KbnZibCKbGldJqiDehGKK60mfXmUYO2twaKcZ0+J3 X-Received: by 2002:a05:6402:297:: with SMTP id l23mr17348351edv.145.1597705269230; Mon, 17 Aug 2020 16:01:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597705269; cv=none; d=google.com; s=arc-20160816; b=Fz+mDBhiVJcSeFJkP7h4ko94qoF1EQRxEfthik6DS9E316Xfd3b77MUCUZbG/p5G3X kxkufR640HnoCsdzjrCx96m1SRIUjGk4lK43ueyKjndEdR9pqk0wKBlPX3X8CTbLgJpK 3IZEke3jFiKfRdMxkwjFhPNBt6obZbA4KvL8mFNgGnpVnJgoKK3ALTrj8M0PVbKYelA8 Jyof144mapftMSk0xF5Ufw5wyP7B68tWQiCRgUUL6+tUnUAMq0mFbgIiUemlQw/WKv9K Vb6Cgsw1s98uUcddRy7Fq9fKA/V6apKxzwEHTeeg3NxfU4oBbMUcEW1QDWzUA+apVMUf BgDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:mime-version :message-id:date:dkim-signature; bh=UNmPgd9kNtZoo9wgw4gsRYDyNuPIjwok9mt363/DTg4=; b=LiLAUuzyXlvq5Letswa+sICOSShDY77jbajF9b4BHgEAUHs/pnMrhmhsFfPVHu+SUO rmGK+entDod+rqrLhvxN4yTxi8PvuMdjjifbRIwSFIzlW+8088JOt8Yz7zNseviYpHYc TRaNEKx+0OA7xB164S9kOo+SimNKFu05E8rfAIp3zUZPelcSOtcFpzVAo0cbYK+BZS7h faUFj1oo7DuT3eTIeW/d/TMBHnb0guTMlndNo5jpDmTSy6iC26PBO0fW5uZEOtFXG3bS sRLXxN1up+viP/WWhvitvM86aYPJ/FO9jzvHsFMOCl9z+4wp+6NQwsYan/m3uTOn4QNS y7hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=NtAgfKUI; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zh8si13962108ejb.475.2020.08.17.16.00.22; Mon, 17 Aug 2020 16:01:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=NtAgfKUI; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726581AbgHQUmC (ORCPT + 99 others); Mon, 17 Aug 2020 16:42:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726361AbgHQUmB (ORCPT ); Mon, 17 Aug 2020 16:42:01 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10A7FC061389 for ; Mon, 17 Aug 2020 13:42:01 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id l13so19821035ybf.5 for ; Mon, 17 Aug 2020 13:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=UNmPgd9kNtZoo9wgw4gsRYDyNuPIjwok9mt363/DTg4=; b=NtAgfKUIXsJ8BR+6PY8e+bttLBBpQL476nDd1QiQpMCDbP+YtSZ3+eLUOnYhSeqOrK KfFa/AI9tex97TLNnfJgbtKZK2ytqPHA0C+a6s6TYz6p5Sv/JqHKeWRDmqD2tK63aEv0 AKC8SEQwsQv80pfaiRAynQhSNO3WY+d8Jq6WSdU0On5W06mCM6g3EjiUr7nhGIGHsuY8 lCC1TA5ZdUVoWlBHS/mAN1Qd2gYl/Y/f8av7jSOAs9rYUNJNaLgOQKJMPqABwz7jzVs0 HUg+SttY8VcC6Ks9zGJPDxKeOWldaPI3VqltP4OzGfseeOhEZ++nNn7f2zdNpOhypJe2 0emA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=UNmPgd9kNtZoo9wgw4gsRYDyNuPIjwok9mt363/DTg4=; b=BEkiJkCKv6/MeOA1wTgPSjztZfE1rWFQ41blpykOeuW/xhhc8aq6CLIZ29jKGS4Xpz +FuXDYY5/OGpw/QGaLOE+MxmK7io+6sMlgBNpFkBB6K0GQ+Qjq7Swwm7F7/LB9KdysHg deBwEaRQp8DZjSrQcP2XcvphCHMkJggcxrg+z6Kz1ANPLmUCDfEb2ZE5yM9dqz4y/D94 LIpPc31ADG6dAqJp5oApk0LHNVDzM+MiJFs+ASAkJRGQYcJGvlR/GJy9dQh3JIReNGAZ UPTyvz2PAOws1GCmDrBSIQI1oeJDonvq4S3I8rWBSzPmqmMX/XpmuMSUqf63OHZ8fRhK vQxQ== X-Gm-Message-State: AOAM532t1YdHytEQvpC69jM+HErB5R2KouZdhQHPbd7Ak7jhsXTyb51m +WbtAE1l2HTamaeGmHLic1gf8CJ6JUWEBEBVEPgYWj9tUQRbjjWDE3mL0DE23A3yPHMpgc9A/m1 tx/uobiTp34fT6XyNME3GMsQSLcBpD+0lj2jr7ulwoXKRQO6Y4ntGgW5xVD5eHLEso6OM2SnqTZ r7 X-Received: by 2002:a25:53c6:: with SMTP id h189mr23476248ybb.469.1597696920076; Mon, 17 Aug 2020 13:42:00 -0700 (PDT) Date: Mon, 17 Aug 2020 13:41:53 -0700 Message-Id: <20200817134133.Bluez.v1.1.I21d21871d85db48b07ba847742c7cb933024307c@changeid> Mime-Version: 1.0 X-Mailer: git-send-email 2.28.0.220.ged08abb693-goog Subject: [Bluez PATCH v1] adapter- Device needs to be in the temporary state after pairing failure. From: Yu Liu To: linux-bluetooth@vger.kernel.org Cc: chromeos-bluetooth-upstreaming@chromium.org, Yu Liu , sonnysasaka@chromium.org Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org This caused the device hanging around as a discovered device forever even if it is turned off or not in present. Reviewed-by: sonnysasaka@chromium.org --- Changes in v1: - Initial change src/device.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/device.c b/src/device.c index bb8e07e8f..93e71850c 100644 --- a/src/device.c +++ b/src/device.c @@ -6008,6 +6008,12 @@ void device_bonding_complete(struct btd_device *device, uint8_t bdaddr_type, if (status) { device_cancel_authentication(device, TRUE); + + // Put the device back to the temporary state so that it will be + // treated as a newly discovered device. + if (!device_is_paired(device, bdaddr_type)) + btd_device_set_temporary(device, true); + device_bonding_failed(device, status); return; } -- 2.28.0.220.ged08abb693-goog