Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200803235811.2441774-1-yudiliu@google.com> <20200803165804.RFC.v1.1.Ibaa1dfd49179a141c19a651f3c2132a28b71b344@changeid>
 <7D5EF527-14F0-42C2-B39B-50B55F01BE74@holtmann.org>
In-Reply-To: <7D5EF527-14F0-42C2-B39B-50B55F01BE74@holtmann.org>
From:   Yu Liu <yudiliu@google.com>
Date:   Mon, 17 Aug 2020 14:28:11 -0700
Message-ID: <CAHC-ybzq91aAHWtQUt_4PN9OF0yzXsW_7dWR37go6Q5+Cjre=A@mail.gmail.com>
Subject: Re: [RFC PATCH v1 1/1] adapter - D-Bus API for querying the adapter's capability
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel,

Thanks for the suggestion, after talking to the original author we
dropped the original idea and added the new API as suggested. Thanks.


On Wed, Aug 12, 2020 at 5:13 AM Marcel Holtmann <marcel@holtmann.org> wrote=
:
>
> Hi Yu,
>
> > Initially this is introduced to query whether WBS is supported by the a=
dapter,
> > the API is generic enough to be extended to support querying others in
> > the future.
> >
> > Reviewed-by: sonnysasaka@chromium.org
> >
> > ---
> >
> > Changes in v1:
> > - Initial change
> >
> > doc/adapter-api.txt | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> > index 1a7255750..250d0e9b3 100644
> > --- a/doc/adapter-api.txt
> > +++ b/doc/adapter-api.txt
> > @@ -204,6 +204,23 @@ Methods          void StartDiscovery()
> >                                        org.bluez.Error.NotReady
> >                                        org.bluez.Error.Failed
> >
> > +             dict GetSupportedCapabilities()
> > +
> > +                     This method returns a dictionary of supported
> > +                     capabilities that is populated when the adapter
> > +                     initiated.
> > +
> > +                     The dictionary is following the format
> > +                     {capability : value}, where:
> > +
> > +                     string capability:      The supported capability =
under
> > +                                             discussion.
> > +                     variant value:          A more detailed descripti=
on of
> > +                                             the capability.
> > +
> > +                     Possible errors: org.bluez.Error.NotReady
> > +                                      org.bluez.Error.Failed
>
> can=E2=80=99t this be just an array{string} that lists the capabilities?
>
> And if we introduce it, then lets introduce it also with the first user o=
f it. Otherwise we end up forgetting to comment on the actual possible capa=
bilities.
>
> Regards
>
> Marcel
>