Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200821062526.16689-1-sonnysasaka@chromium.org>
In-Reply-To: <20200821062526.16689-1-sonnysasaka@chromium.org>
From:   Sonny Sasaka <sonnysasaka@chromium.org>
Date:   Fri, 21 Aug 2020 00:11:28 -0700
Message-ID: <CAO271m=eB=HRUXReW8BUWooU5mfz=yQfwq0Dp1KZyWbqc9KPCg@mail.gmail.com>
Subject: Re: [PATCH BlueZ] device: unset disconnecting flag when connection is removed
To:     BlueZ <linux-bluetooth@vger.kernel.org>
Cc:     Joseph Hwang <josephsih@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Dear Maintainers,

Please ignore this patch as it is broken. Apologize for the mistake.


On Thu, Aug 20, 2020 at 11:25 PM Sonny Sasaka <sonnysasaka@chromium.org> wrote:
>
> From: Joseph Hwang <josephsih@chromium.org>
>
> A disconnecting flag has been used to avoid race condition
> between the service browsing thread and the disconnecting
> thread. We need to unset the flag when connection is removed.
>
> ---
>  src/device.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/device.c b/src/device.c
> index 7b7808405..5ab591dd4 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -3041,6 +3041,9 @@ void device_remove_connection(struct btd_device *device, uint8_t bdaddr_type)
>                                                         "Paired");
>         }
>
> +       if (device)
> +               set_client_diconnecting(device->client, false);
> +
>         if (device->bredr_state.connected || device->le_state.connected)
>                 return;
>
> --
> 2.26.2
>