Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1162347pxk; Mon, 31 Aug 2020 11:28:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWT9apc5frg8FFYvhNpXa3FKtP381nTCROrWBQR7eKIusjxBHfabuX3APiAKTjNRUhiKxr X-Received: by 2002:a50:d78e:: with SMTP id w14mr2339915edi.229.1598898524090; Mon, 31 Aug 2020 11:28:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598898524; cv=none; d=google.com; s=arc-20160816; b=nGQCDwcU0s0EhLOIIHvLT7kqSKoAN9mHFZz4vZaKyry3V8WRvemEy7nBfD8vYn5uqL dP/HtPpsicAjlQqa9AncbFxfApDzkVcgTd+mlXpGPRlPUKCepDL8RQEdD81RTurMWwqY ZOHPcG6JRjuvsGmG7yJHsyAYJPNLPuHgJQRFHuIvV6rfnBht0ngnDHu4SBfVdn2WLaV6 tlzNYgvqdPNPRZlcaVJvU7YoqKqFL0yM/Jb1JdlJs3VoI+TaXLj1/j2G+1sosOuKQPzx WvLnMTWP6I7ha8B4jXJ1n6xkreXV5/Z54em+vmgODIyxjyfbLdchM7Sog+B+BYmPVjlH PhOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=h63Rj0Px9YhpYpjPVZddoHDJIC9AXL8x7ZQiNvu7YH4=; b=PWdwK7P7AJSJw+vZzQgZGsz3m5BILb4NVUdrHziHqmbKHVEG4kRzIVWQT6mIRFHD/6 lIcI8D1rjBNizD8YYo8VzhhkDooe1B2tOcpW0TJ/ezswSkhhC+4Feumcph8HVyZ3XSeB c7jICNt6hPt9q/UZO91Jkz76lol0O4sCGqfaxnVbxgQDrNYL+ZbRLhppar/zpv8fAYco io/Sh07V+w0s+soyiliSLqpMP44s/oVfvhIAp+DIH3tFIC+xl9PbhP3smTBHw17mKlrR Y4/515ErCt8ZFiR1TZoXtJJuhLkjMD1UvQqbZ4xgFS0s6Q5QXRu4Aw6yZXiTzUvb5aRr vt6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="SyTl/NwA"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r12si5663856edq.93.2020.08.31.11.28.19; Mon, 31 Aug 2020 11:28:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="SyTl/NwA"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728235AbgHaS2R (ORCPT + 99 others); Mon, 31 Aug 2020 14:28:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726174AbgHaS2Q (ORCPT ); Mon, 31 Aug 2020 14:28:16 -0400 Received: from mail-vk1-xa44.google.com (mail-vk1-xa44.google.com [IPv6:2607:f8b0:4864:20::a44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F588C061573 for ; Mon, 31 Aug 2020 11:28:16 -0700 (PDT) Received: by mail-vk1-xa44.google.com with SMTP id e5so407213vkm.2 for ; Mon, 31 Aug 2020 11:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h63Rj0Px9YhpYpjPVZddoHDJIC9AXL8x7ZQiNvu7YH4=; b=SyTl/NwAvI6Z6KVO9hDikmuv6SASItxkTxMNDTqAvF6VBnY5jPJ7rvJ3Mx9AaFDQKj UeBTwv1rI8/u4EKJVwI+UrBUKSXaGclHnuyf0hWiZQjYUnjJJiVfm4SxHYiPEHHS6Qpf ma5FSM5rtT0JqGw8j7E8WyYjtkkmjwm3KjUAc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h63Rj0Px9YhpYpjPVZddoHDJIC9AXL8x7ZQiNvu7YH4=; b=W/UUfowP8bViEud16iNYrs+9iL28JKURBmBPKUHUkk8sr6TUcFlYDW9fgdPkwpcFZn Zlh99rALZEf5qZlqfbLkE26tms/dzPB4BzRbLeNtYW9qVVmHbyG94YGPXGeTTms67jRu 0nJygxOmE+4vXZpxsivyEplExW7qDfYZV3RTZRT+yzYjvZpjY4NKqPC/kQoYWeLFf6Rc DCj8563x/isclSB/kZd7Z+BVPGgUVUcFSAtMEmgslXdYj38CKVY2dVBCaqCLYCExP69K cJgZ2tYWT9CcKSNtrP/ZaKBcnQXkL/iXSGa4K1WC0edjXqMUmPipqv71G6j63ZkczS/Y DDdA== X-Gm-Message-State: AOAM531L2ZGhbLgv1k5Tl33mf28FuVAM2eiL3Ep+0AeTDwZp9WAQp50D EuIxUJ5aJYqjVKUxi2ILxaNa+5xzQ+CRtdKzwu4lpg== X-Received: by 2002:ac5:c925:: with SMTP id u5mr2185373vkl.68.1598898495413; Mon, 31 Aug 2020 11:28:15 -0700 (PDT) MIME-Version: 1.0 References: <20200829010210.871471-1-abhishekpandit@chromium.org> <20200828180157.Bluez.v3.1.I14a96397d181666c124e1c413b834428faf3db7a@changeid> In-Reply-To: From: Abhishek Pandit-Subedi Date: Mon, 31 Aug 2020 11:28:05 -0700 Message-ID: Subject: Re: [Bluez PATCH v3 1/3] mgmt: Add controller suspend and resume events To: Luiz Augusto von Dentz Cc: Marcel Holtmann , ChromeOS Bluetooth Upstreaming , "linux-bluetooth@vger.kernel.org" , Sonny Sasaka Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Luiz, Could you also merge https://patchwork.kernel.org/patch/11663455/ that adds this to docs/mgmt-api.txt? Thanks Abhishek On Mon, Aug 31, 2020 at 10:36 AM Luiz Augusto von Dentz wrote: > > Hi Abhishek, > > On Fri, Aug 28, 2020 at 6:02 PM Abhishek Pandit-Subedi > wrote: > > > > Add the controller suspend and resume events. > > > > Reviewed-by: Sonny Sasaka > > --- > > > > Changes in v3: None > > Changes in v2: None > > > > lib/mgmt.h | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/lib/mgmt.h b/lib/mgmt.h > > index a800bcab4..46d894ae9 100644 > > --- a/lib/mgmt.h > > +++ b/lib/mgmt.h > > @@ -772,6 +772,7 @@ struct mgmt_ev_device_connected { > > #define MGMT_DEV_DISCONN_TIMEOUT 0x01 > > #define MGMT_DEV_DISCONN_LOCAL_HOST 0x02 > > #define MGMT_DEV_DISCONN_REMOTE 0x03 > > +#define MGMT_DEV_DISCONN_LOCAL_HOST_SUSPEND 0x05 > > > > #define MGMT_EV_DEVICE_DISCONNECTED 0x000C > > struct mgmt_ev_device_disconnected { > > @@ -959,6 +960,17 @@ struct mgmt_ev_adv_monitor_removed { > > uint16_t monitor_handle; > > } __packed; > > > > +#define MGMT_EV_CONTROLLER_SUSPEND 0x002d > > +struct mgmt_ev_controller_suspend { > > + uint8_t suspend_state; > > +} __packed; > > + > > +#define MGMT_EV_CONTROLLER_RESUME 0x002e > > +struct mgmt_ev_controller_resume { > > + struct mgmt_addr_info addr; > > + uint8_t wake_reason; > > +} __packed; > > + > > static const char *mgmt_op[] = { > > "<0x0000>", > > "Read Version", > > @@ -1088,6 +1100,8 @@ static const char *mgmt_ev[] = { > > "Device Flags Changed", > > "Advertisement Monitor Added", /* 0x002b */ > > "Advertisement Monitor Removed", > > + "Controller Suspend", > > + "Controller Resume", > > }; > > > > static const char *mgmt_status[] = { > > -- > > 2.28.0.402.g5ffc5be6b7-goog > > Patches 1 and 2 of this series were applied, thanks. > > -- > Luiz Augusto von Dentz