Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200817212554.3844965-1-yudiliu@google.com> <20200817142545.RFC.v2.1.Ibaa1dfd49179a141c19a651f3c2132a28b71b344@changeid>
 <CABBYNZLRqhB6d5Hm7_RqvUqCJo11D4+pgYLCeWj0j=8dZk0Bcg@mail.gmail.com> <CAHC-ybxshy5zmkAku6suicvjO0Ngofp0+gRyYLX_RXr9YhU94Q@mail.gmail.com>
In-Reply-To: <CAHC-ybxshy5zmkAku6suicvjO0Ngofp0+gRyYLX_RXr9YhU94Q@mail.gmail.com>
From:   Yu Liu <yudiliu@google.com>
Date:   Mon, 31 Aug 2020 14:44:11 -0700
Message-ID: <CAHC-ybxFY_3HWrvnwF5DS-i-YJtYpUuR9K3-MSWJWo=C-CKQHA@mail.gmail.com>
Subject: Re: [RFC PATCH v2 1/1] adapter - D-Bus API for querying the adapter's capabilities
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Alain Michaud <alainmichaud@google.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>,
        Archie Pusaka <apusaka@chromium.org>,
        Sonny Sasaka <sonnysasaka@chromium.org>,
        Marcel Holtmann <marcel@holtmann.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

+Alain Michaud

Hi Marcel,

Can you please comment on the cl as well as Luiz's suggestion? Thanks.

On Thu, Aug 20, 2020 at 10:20 AM Yu Liu <yudiliu@google.com> wrote:
>
> Friendly ping for comments from Marcel. Thanks.
>
>
> On Mon, Aug 17, 2020 at 4:17 PM Luiz Augusto von Dentz
> <luiz.dentz@gmail.com> wrote:
> >
> > Hi Marcel,
> >
> > On Mon, Aug 17, 2020 at 4:07 PM Yu Liu <yudiliu@google.com> wrote:
> > >
> > > From: Archie Pusaka <apusaka@chromium.org>
> > >
> > > Initially this is introduced to query whether WBS is supported by the adapter,
> > > the API is generic enough to be extended to support querying others in
> > > the future.
> > >
> > > Reviewed-by: sonnysasaka@chromium.org
> > >
> > > Signed-off-by: Yu Liu <yudiliu@google.com>
> > > ---
> > >
> > > Changes in v2:
> > > - Return an array of strings instead of a dict
> > >
> > > Changes in v1:
> > > - Initial change
> > >
> > >  doc/adapter-api.txt | 12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > >
> > > diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> > > index 1a7255750..8fbcadb54 100644
> > > --- a/doc/adapter-api.txt
> > > +++ b/doc/adapter-api.txt
> > > @@ -204,6 +204,18 @@ Methods            void StartDiscovery()
> > >                                          org.bluez.Error.NotReady
> > >                                          org.bluez.Error.Failed
> > >
> > > +               array{string} GetCapabilities()
> > > +
> > > +                       This method returns a list of supported
> > > +                       capabilities that is populated when the adapter
> > > +                       initiated.
> > > +
> > > +                       Possible values:
> > > +                               "wbs" - Wide band speech
> >
> > Btw, should we stick to use wbs terminology here, or we should
> > actually use the HCI feature/command, because wbs has actually to be
> > implemented by the HFP afaik this is only indicating that the
> > controller is able to notify packets drops, etc, with use of erroneous
> > command. Perhaps we should actually use the term PLC (Packet Loss
> > Concealment) instead since that seems to be the real capability here,
> > afaik WBS does not actually require PLC.
> >
> > > +
> > > +                       Possible errors: org.bluez.Error.NotReady
> > > +                                        org.bluez.Error.Failed
> > > +
> > >  Properties     string Address [readonly]
> > >
> > >                         The Bluetooth device address.
> > > --
> > > 2.28.0.220.ged08abb693-goog
> > >
> >
> >
> > --
> > Luiz Augusto von Dentz