Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp62641pxk; Thu, 10 Sep 2020 23:52:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyv30V1F4LMq1bQExbp8zz5KtnPzQuLeow8oL7tVQmSViAgMQw50w3XUPZeTHv89EbEXVL8 X-Received: by 2002:a17:906:7116:: with SMTP id x22mr696400ejj.426.1599807166574; Thu, 10 Sep 2020 23:52:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599807166; cv=none; d=google.com; s=arc-20160816; b=VkjKUWkm6DaTvyuokd55xlecZGGfzIdAAzqtYg9rrYQ8pC4ISflOMUR9AM0Y/6Rw48 Kkv7+rbq8WhZH8XseszjgOMoMfDgdG7OTQfRQPUm2tFL1vzVlZfMmKG+1WZfxW9WEpRN SKWBbgSZcjVrTvpDqqHJOa9wxIZUWWBG8DQwMa+oktFM48TKcKpoptMjJQ3bROiH6yqE jNVIqZaVPFKBF855HzYv4JNokaU1J8FlQnzo8o1CWHrIjnyaSOy/YC0o5l+VvigZWAfD 9Gs3fFnBwc+CZ1miXTuUfg3IR94H1glj4IMmyzvTGAhLMdiYLpKDgqjOYdrDws+nkUop 5z8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=uFMuNjmNJEzgSrQ8jCfPzawYf4AVp0d8/sUQ/WO3+Js=; b=iQwTQ+J+c5uMscUd80cHH/8EA7UmZUDADN25If6CeO7O7IUZgHug5+34PV6fNLCk6O YEeBeTpz+ziKqLfwAsTUBh/mBryekPI0FD4QMG92KxonnLqiRtYyZM8OGI/L6EntMEEc TExkPrlOxnLNOlL7VG3ZeruPu/SSJQoInX8R7Nkcuwaaez/ND2VeHqyPIKigGFKlXodv wv6ckV3PjwRzIU4b6xhzYH98yGrcBdgwVgtKL8VYW9WVgnGzlCZPatfzaMcpyZ2UpQp4 jl20ajYbrZ1i9rMQgkZlcTHQle3H2YI5reI49SlC78VQTm/Hpo0pINzOEggMSsFxZj2Z kH4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j20si674582eds.200.2020.09.10.23.52.16; Thu, 10 Sep 2020 23:52:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725799AbgIKGvR (ORCPT + 99 others); Fri, 11 Sep 2020 02:51:17 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:44643 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725785AbgIKGvQ (ORCPT ); Fri, 11 Sep 2020 02:51:16 -0400 Received: from marcel-macbook.fritz.box (p4ff9f430.dip0.t-ipconnect.de [79.249.244.48]) by mail.holtmann.org (Postfix) with ESMTPSA id B471FCED1B; Fri, 11 Sep 2020 08:58:10 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH] Bluetooth: hci_qca: remove redundant null check From: Marcel Holtmann In-Reply-To: <20200903082719.85027-1-vulab@iscas.ac.cn> Date: Fri, 11 Sep 2020 08:51:15 +0200 Cc: Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <95E38C5D-0F97-4BDA-AC14-F4DBBD1F214A@holtmann.org> References: <20200903082719.85027-1-vulab@iscas.ac.cn> To: Xu Wang X-Mailer: Apple Mail (2.3608.120.23.2.1) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Xu, > Because clk_disable_unprepare already checked > NULL clock parameter, so the additional check is > unnecessary, just remove it. > > Signed-off-by: Xu Wang > --- > drivers/bluetooth/hci_qca.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel