Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1398226pxk; Sun, 13 Sep 2020 00:59:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEt2wsHK5HlZF/cYNhPOszcpqoU/JPvjwM8urHjLnkOsGUd5JO7VABGsTldwaZjoxmIuH3 X-Received: by 2002:aa7:d417:: with SMTP id z23mr11269790edq.62.1599983969251; Sun, 13 Sep 2020 00:59:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599983969; cv=none; d=google.com; s=arc-20160816; b=tuSWi/soVgXlgLkUyVUPP7L/OfaP5IpfjqvtH4o+NEL1tfQSBruSNaG3Knx9pIl5K6 nuVaORZlkePwz3NCalKBDsBED6v41oTfXzS1hIip/t6VDNo1CRdW3+MJ1JyAISLm9Z2Y 3ojlt70XXcfI2LYzwr9a2Wlsdrl50UTty+mEmhSJ5m5B6yPJ7ysq5gxlEBIUxouI5PKG f3VEgHi9qp5RatRHC3bWClE/FbS6svkHXX212023WfqjVrKoGqTvbuQLMWQO+EqNtW6l noekTz2mGKo7kTT6U8vVlTsOk5dSAp8HID/ZyQDSYvkMTXYzQXhr4ttFyUs6a66SO7XL aWrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=US0+n3WcH+s9vpVy0IXtAo2HyvOH9lwLAi867/lljOs=; b=zKJJSZnHIkzPIWVX9dN/ZwGIlSqjIpunldXyrDnKcKAl5TsmO9PRcsJUuz6lv5khye idRkgxtBHAYOtQ8K1Ao1l1Ak3yhTn1yE3XqPYvcKgdTDjmJrtw6vbYe7Mbh4Xwy2V9Uu e02bpVyEhqkY86seyd5tbY4ZcSw0FjPu3dv+RJnELl+xJG28xFq0wNkT3SSh9vVkxsK8 tZV8HirI4pglNHf/8dzltPVsH5NEAjgm75Qx8rD5uvdddpt5EBa95Ltt31U8+3kzChzH iPBtRaUlOg2ect+vBVM6sLq5enIxOn539Z7KoeVb6SwtWU363IfqOlV2C9QcWJxlZJ0S BHUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn20si5573573ejc.196.2020.09.13.00.59.03; Sun, 13 Sep 2020 00:59:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725916AbgIMH7A (ORCPT + 99 others); Sun, 13 Sep 2020 03:59:00 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:52930 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbgIMH66 (ORCPT ); Sun, 13 Sep 2020 03:58:58 -0400 Received: from marcel-macbook.fritz.box (p4ff9f430.dip0.t-ipconnect.de [79.249.244.48]) by mail.holtmann.org (Postfix) with ESMTPSA id E268DCECC4; Sun, 13 Sep 2020 10:05:52 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH v1] Bluetooth: btintel: Refactor firmware download function From: Marcel Holtmann In-Reply-To: <1599824657-19464-1-git-send-email-kiran.k@intel.com> Date: Sun, 13 Sep 2020 09:58:56 +0200 Cc: linux-bluetooth , Kiran K Content-Transfer-Encoding: 7bit Message-Id: <02F01161-2498-4A89-A8B5-3F19D62143E0@holtmann.org> References: <1599824657-19464-1-git-send-email-kiran.k@intel.com> To: Kiran K X-Mailer: Apple Mail (2.3608.120.23.2.1) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Kiran, > Split firmware download code into two functions - one to download > header and other to download payload. This patch enhances readability > and reusabiltiy of code > > Signed-off-by: Kiran K > Reviewed-by: Chethan T N > Reviewed-by: Sathish Narasimman > Reviewed-by: Srivatsa Ravishankar > --- > drivers/bluetooth/btintel.c | 35 ++++++++++++++++++++++++++++++----- > 1 file changed, 30 insertions(+), 5 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel