Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp276937pxk; Thu, 17 Sep 2020 02:49:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXZqOP4t+P/Kf701ZF5GIIMrYurJU6s6m5KZqd6rgZIS885D/zh/BXAHmsc+C+Ai8HBKPy X-Received: by 2002:a17:907:444f:: with SMTP id on23mr28996548ejb.392.1600336183091; Thu, 17 Sep 2020 02:49:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600336183; cv=none; d=google.com; s=arc-20160816; b=DQCSgyf+4Wpx5Axf7DNK/bRwev203UpKOje4CdIst6qvt6nS388but+91ZL+TK0Kf4 rnklhjKe3j175blVsTXLjeIKXUO3tWtsm82c1Sw3kqE1J4lEXh4LMZylxojHM517xoGp CiAfQZsO4MbMCpcvSp0hx9bjmWPXHFzroSJFwnJNe+tm9og2Vbz5LpMgyuUGfoqsWAoa EbVw9+pinnEmH9SYNFMSMYY1KJhPNJKPbWsd4f7aT6WtZDp4JBPsBbONA+xSQJ+JdWyI otu4X+fdkwVsmmiSsSz8Dj1EI90y3AHou7DuOz8erKdEb5unn0iFZJbquU90eLd9QHAH fg3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=zzzAajF3eU3ktjRdICJvMgTcLa2HSIahRG5HTonz438=; b=csQ7KzPi0g/a77RZaBSPbGLpD8l2+Y5EQ+c50E94xw4mWkFxRFNWdu7rq2b5qB8auV RBACtcnviygpZvmonPTCzlo2inGYNTyPrvthmvjB7HXASqBQlctsHO5wr8t+YQS9/uAC APYgdfHHTPafAdX93bHBbHjEF+g+fTCSWEOftCukA0spmNPwXXBmfqUgYGnpeibXtdBq cwfmwazI7Rdm9LiOhtZF7Bc+GeaxeZ0rQiKUh0CFOoxNIaJFKBWglyfTcjvUEDtGvumJ 4DC+HOA2htRWPh4yCbHr86YXLJxiFDoPHg6iezoqLB7kgUycDCiYNqtk2P/bc4GD+cOg +t0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y4si6290229edp.279.2020.09.17.02.49.05; Thu, 17 Sep 2020 02:49:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726368AbgIQJrV (ORCPT + 99 others); Thu, 17 Sep 2020 05:47:21 -0400 Received: from mslow2.mail.gandi.net ([217.70.178.242]:52592 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbgIQJrU (ORCPT ); Thu, 17 Sep 2020 05:47:20 -0400 X-Greylist: delayed 2229 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Sep 2020 05:47:20 EDT Received: from relay7-d.mail.gandi.net (unknown [217.70.183.200]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 96A3C3A3028 for ; Thu, 17 Sep 2020 08:56:29 +0000 (UTC) X-Originating-IP: 82.255.60.242 Received: from [192.168.0.28] (lns-bzn-39-82-255-60-242.adsl.proxad.net [82.255.60.242]) (Authenticated sender: hadess@hadess.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 8C0F620010; Thu, 17 Sep 2020 08:56:06 +0000 (UTC) Message-ID: Subject: Re: [PATCH BlueZ v2] sixaxis: Fix crash caused by return of udev_device_get_property_value From: Bastien Nocera To: Sonny Sasaka , linux-bluetooth@vger.kernel.org Cc: Miao-chen Chou , Yoni Shavit , Alain Michaud Date: Thu, 17 Sep 2020 10:56:05 +0200 In-Reply-To: <20200916223453.22537-1-sonnysasaka@chromium.org> References: <20200916223453.22537-1-sonnysasaka@chromium.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.37.90 (3.37.90-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Wed, 2020-09-16 at 15:34 -0700, Sonny Sasaka wrote: > From: Miao-chen Chou > > This adds a NULL check before calling sscanf(). > > Reviewed-by: Yoni Shavit > Reviewed-by: Alain Michaud Looks good. Reviewed-by: Bastien Nocera