Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
From:   Miao-chen Chou <mcchou@chromium.org>
Date:   Fri, 18 Sep 2020 12:38:21 -0700
Message-ID: <CABmPvSHYi7WeWqgqxSe60omSyVXj_EezMhGi1GMXBBWM-TWeBw@mail.gmail.com>
Subject: Modifying Makefile.am to facilitate test-adv-monitor and future unit tests.
To:     Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>,
        Marcel Holtmann <marcel@holtmann.org>,
        Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Cc:     Alain Michaud <alainm@chromium.org>,
        Manish Mandlik <mmandlik@chromium.org>,
        Howard Chung <howardchung@google.com>,
        Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Luiz and Marcel,

Unlike the rest of the existing unit tests in BlueZ, the logic blocks
tested in test-adv-monitor require dependencies of not only
src/adv_monitor.c but also all the dependency tree of
src/adv_monitor.c. The current convention in Makefile.am is to add all
the extra dependencies one by one. However, the maintenance cost is
high and not suitable in the case of test-adv-monitor. Therefore, we'd
like to propose changes in Makefile.am to make the source of
bluetoothd as a static library and link it for bluetoothd target and
the unit test target. It would be great if you can provide feedback on
this idea before the implementation. Thanks in advance!

Regards,
Miao