Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CABmPvSHYi7WeWqgqxSe60omSyVXj_EezMhGi1GMXBBWM-TWeBw@mail.gmail.com>
In-Reply-To: <CABmPvSHYi7WeWqgqxSe60omSyVXj_EezMhGi1GMXBBWM-TWeBw@mail.gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 18 Sep 2020 15:12:12 -0700
Message-ID: <CABBYNZJDbPd83cx0KWLGMpE_KaA9xUbuMCDsuQVTNxV7xrowiw@mail.gmail.com>
Subject: Re: Modifying Makefile.am to facilitate test-adv-monitor and future
 unit tests.
To:     Miao-chen Chou <mcchou@chromium.org>
Cc:     Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>,
        Marcel Holtmann <marcel@holtmann.org>,
        Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
        Alain Michaud <alainm@chromium.org>,
        Manish Mandlik <mmandlik@chromium.org>,
        Howard Chung <howardchung@google.com>,
        Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Miao,

On Fri, Sep 18, 2020 at 12:44 PM Miao-chen Chou <mcchou@chromium.org> wrote:
>
> Hi Luiz and Marcel,
>
> Unlike the rest of the existing unit tests in BlueZ, the logic blocks
> tested in test-adv-monitor require dependencies of not only
> src/adv_monitor.c but also all the dependency tree of
> src/adv_monitor.c. The current convention in Makefile.am is to add all
> the extra dependencies one by one. However, the maintenance cost is
> high and not suitable in the case of test-adv-monitor. Therefore, we'd
> like to propose changes in Makefile.am to make the source of
> bluetoothd as a static library and link it for bluetoothd target and
> the unit test target. It would be great if you can provide feedback on
> this idea before the implementation. Thanks in advance!

Then we should have had the code move to src/shared for unit testing,
but how exactly are you planning to do that? For testing the kernel
interface it normally done via a dedicated tester, but that again can
be done with shared library.

> Regards,
> Miao


-- 
Luiz Augusto von Dentz