Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
Subject: Re: [PATCH v2] Bluetooth: Fix auto-creation of hci_conn at Conn
 Complete event
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20200814190909.361764-1-sonnysasaka@chromium.org>
Date:   Sun, 20 Sep 2020 08:22:31 +0200
Cc:     linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Content-Transfer-Encoding: 7bit
Message-Id: <AD524EC5-2AC9-4B3A-ACC9-E896E5EFCB2A@holtmann.org>
References: <20200814190909.361764-1-sonnysasaka@chromium.org>
To:     Sonny Sasaka <sonnysasaka@chromium.org>
Precedence: bulk

Hi Sonny,

> Currently the code auto-creates hci_conn only if the remote address has
> been discovered before. This may not be the case. For example, the
> remote device may trigger connection after reboot at already-paired
> state so there is no inquiry result found, but it is still correct to
> create the hci_conn when Connection Complete event is received.
> 
> A better guard is to check against bredr allowlist. Devices in the
> allowlist have been given permission to auto-connect.
> 
> Fixes: 4f40afc6c764 ("Bluetooth: Handle BR/EDR devices during suspend")
> Signed-off-by: Sonny Sasaka <sonnysasaka@chromium.org>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> 
> ---
> net/bluetooth/hci_event.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel