Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: CEc2g8912Pqv1s6G7EDFskEwH6IsmEOhHPayWgaAIOTAMvibSbExClX4Bug6JdmTuWOJUWZH7K
 xUvdCze1NP6A==
IronPort-SDR: 7wZQkjnRWqNgMPSK/6fH/cyprwHD5Iw/9qqMxhV8i7rLYKgFpEzAsTSPz1cIQe5QECaMWcD7C/
 /7Ag4/n+NfHw==
From:   "K, Kiran" <kiran.k@intel.com>
To:     Marcel Holtmann <marcel@holtmann.org>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>
CC:     Kiran K <kiraank@gmail.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "Narasimman, Sathish" <sathish.narasimman@intel.com>,
        "Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>,
        "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
        "Bag, Amit K" <amit.k.bag@intel.com>,
        Raghuram Hegde <raghuram.hegde@intel.com>
Subject: RE: [PATCH v4] Bluetooth: btintel: Add *setup* function for new
 generation Intel controllers
Thread-Topic: [PATCH v4] Bluetooth: btintel: Add *setup* function for new
 generation Intel controllers
Thread-Index: AQHWmIirS4SOjPuc5EmhHpIj0oveQamEm0yAgADUGACAAAnu8A==
Date:   Sat, 3 Oct 2020 07:27:47 +0000
Message-ID: <BYAPR11MB31418F814CF72BABA4AF8970F50E0@BYAPR11MB3141.namprd11.prod.outlook.com>
References: <1601621530-2803-1-git-send-email-kiran.k@intel.com>
 <CABBYNZJW=9p=wV4okj=_WtJjEsZhuh9ZHEB-U_7ZMLEbxJ+UXQ@mail.gmail.com>
 <9E9FAF70-08C3-465A-98C5-2EBCBB50D699@holtmann.org>
In-Reply-To: <9E9FAF70-08C3-465A-98C5-2EBCBB50D699@holtmann.org>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: baf05875-c24d-4400-b1a0-08d8676dd432
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2020 07:27:47.8775
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aRqHsRj3V78+1/24ef8pkavYsBysFZJPtrekgxtDaypYK6IBbwR8R8d+MPyaPkpHdurVmRwVX3IC079IZ0+wsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2824
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Marcel, Luiz,

> -----Original Message-----
> From: Marcel Holtmann <marcel@holtmann.org>
> Sent: Saturday, October 3, 2020 12:12 PM
> To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Cc: Kiran K <kiraank@gmail.com>; linux-bluetooth@vger.kernel.org;
> Narasimman, Sathish <sathish.narasimman@intel.com>; Tumkur Narayan,
> Chethan <chethan.tumkur.narayan@intel.com>; Srivatsa, Ravishankar
> <ravishankar.srivatsa@intel.com>; K, Kiran <kiran.k@intel.com>; Bag, Amit=
 K
> <amit.k.bag@intel.com>; Raghuram Hegde <raghuram.hegde@intel.com>
> Subject: Re: [PATCH v4] Bluetooth: btintel: Add *setup* function for new
> generation Intel controllers
>=20
> Hi Luiz,
>=20
> >> Signed-off-by: Kiran K <kiran.k@intel.com>
> >> Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
> >> Signed-off-by: Raghuram Hegde <raghuram.hegde@intel.com>
> >> Reviewed-by: Sathish Narasimman <Sathish.Narasimman@intel.com>
> >> Reviewed-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> >> Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@intel.com>
> >> ---
> >> drivers/bluetooth/btintel.h |   6 +
> >> drivers/bluetooth/btusb.c   | 324
> +++++++++++++++++++++++++++++++++++++++++++-
> >> 2 files changed, 328 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/bluetooth/btintel.h
> >> b/drivers/bluetooth/btintel.h index 09346ae..c4e28a8 100644
> >> --- a/drivers/bluetooth/btintel.h
> >> +++ b/drivers/bluetooth/btintel.h
> >> @@ -132,6 +132,12 @@ struct intel_debug_features {
> >>        __u8    page1[16];
> >> } __packed;
> >>
> >> +#define INTEL_HW_PLATFORM(cnvx_bt)     ((u8)(((cnvx_bt) & 0x0000ff00)
> >> 8))
> >> +#define INTEL_HW_VARIANT(cnvx_bt)      ((u8)(((cnvx_bt) & 0x003f0000)
> >> 16))
> >> +#define INTEL_CNVX_TOP_TYPE(cnvx_top)  ((cnvx_top) & 0x00000fff)
> >> +#define INTEL_CNVX_TOP_STEP(cnvx_top)  (((cnvx_top) & 0x0f000000)
> >>
> >> +24) #define INTEL_CNVX_TOP_PACK_SWAB(t, s) __swab16(((__u16)(((t)
> <<
> >> +4) | (s))))
> >> +
> >> #if IS_ENABLED(CONFIG_BT_INTEL)
> >>
> >> int btintel_check_bdaddr(struct hci_dev *hdev); diff --git
> >> a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index
> >> 1005b6e..5e51749 100644
> >> --- a/drivers/bluetooth/btusb.c
> >> +++ b/drivers/bluetooth/btusb.c
> >> @@ -60,6 +60,7 @@ static struct usb_driver btusb_driver; #define
> >> BTUSB_WIDEBAND_SPEECH  0x400000
> >> #define BTUSB_VALID_LE_STATES   0x800000
> >> #define BTUSB_QCA_WCN6855      0x1000000
> >> +#define BTUSB_INTEL_NEWGEN     0x2000000
> >
> > I wonder if it is a good idea to keep adding such flags per model
> > here, it should be possible to pass the pid/vid so we don't have to
> > add generation after generation here.
>=20
> We agreed to first add the next gen controller as an independent setup
> method. And then later combine them into a single one that detects what
> version it is. We also need to unify it with our first generation ROM pro=
ducts.

We can still have an independent setup function for next gen controllers. O=
nly the method to identify the controller type is changed to use PID/VID in=
stead of BTUSB_INTEL_NEW. I will submit the refined patch in V5. Please rev=
iew it. If you still feel that we need to use BTUSB_INTEL_NEW, I will rever=
t to v4.
>=20
> Regards
>=20
> Marcel

Thanks,
Kiran