Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
Subject: Re: [PATCH] Revert "Bluetooth: Update resolving list when updating
 whitelist"
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20201003160713.GA1512229@kroah.com>
Date:   Sat, 3 Oct 2020 20:33:18 +0200
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        Sathish Narsimman <sathish.narasimman@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <AABC2831-4E88-41A2-8A20-1BFC88895686@holtmann.org>
References: <20201003135449.GA2691@kroah.com>
 <A1C95238-CBCB-4FD4-B46D-A62AED0C77E5@holtmann.org>
 <20201003160713.GA1512229@kroah.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Precedence: bulk

Hi Greg,

>>> This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it
>>> breaks all bluetooth connections on my machine.
>>> 
>>> Cc: Marcel Holtmann <marcel@holtmann.org>
>>> Cc: Sathish Narsimman <sathish.narasimman@intel.com>
>>> Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating whitelist")
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> ---
>>> net/bluetooth/hci_request.c | 41 ++-----------------------------------
>>> 1 file changed, 2 insertions(+), 39 deletions(-)
>>> 
>>> This has been bugging me for since 5.9-rc1, when all bluetooth devices
>>> stopped working on my desktop system.  I finally got the time to do
>>> bisection today, and it came down to this patch.  Reverting it on top of
>>> 5.9-rc7 restored bluetooth devices and now my input devices properly
>>> work.
>>> 
>>> As it's almost 5.9-final, any chance this can be merged now to fix the
>>> issue?
>> 
>> can you be specific what breaks since our guys and I also think the
>> ChromeOS guys have been testing these series of patches heavily.
> 
> My bluetooth trackball does not connect at all.  With this reverted, it
> all "just works".
> 
> Same I think for a Bluetooth headset, can check that again if you really
> need me to, but the trackball is reliable here.
> 
>> When you run btmon does it indicate any errors?
> 
> How do I run it and where are the errors displayed?

you can do btmon -w trace.log and just let it run like tcdpump.

>> Do you have a chance to test net-next and see the LL Privacy there might have addressed this?
> 
> Have a specific set of patches I can test?  It wouldn't be good to have
> 5.9-final go out with this not working at all.

Of course not, but so far you are the only one reported a problem. Maybe you have some funky hardware in your machine that needs a quirk.

Regards

Marcel