Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp374380pxu; Tue, 6 Oct 2020 08:26:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxU9UG8rCvytxU9F650wddy5ur6mwJ8EXML5H7TMvMKpRalLsY7QylR9X0NGjuxbldwyiWM X-Received: by 2002:a17:906:bc98:: with SMTP id lv24mr5693122ejb.545.1601997996342; Tue, 06 Oct 2020 08:26:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601997996; cv=none; d=google.com; s=arc-20160816; b=rd8VRgY4bHoXI7zx7DWZOX5mph9jngq1gsgssIEXE6MMUylm3j6wtNQi661NcUZc5h DeJ9Jptm7jWYwE6b/s+pDml3tFLS4rwCmhLv/wIXVTslq9+lFMOThLCr7qZ7tp6vTBGt KpPfPg29OUzeYQS83fib9r6Aefb2OqpXJrcqrk6GVVn4V+ox+s4v4C3euGiY4foJsTtN nla/VuNGFdL4pV6XoUqENqTu5nyiMt4Xe04Q5+xmGjcnKdb4oKIViMK1sPQd2M3L3SHM 5eME/SXQshpKrpXAmsjP1bqtCerkiRBPwGOosauUr+RwE59ICyy9Kn1ziw4eHmx0UfDp ncsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MpgtNIMYLlL4bB1Pb4In1NFBTR9GjbE0/qeHo4XPlDo=; b=IrMyT4MZUGjW2c04CUBlnPkE88IB1B3Ip8LlXcD+uAqMEjjxZC+VJ+RGGgTLNnPhot qB3zJlf/gqY3Eckf01l3ysJ48XrLxETtsU5nwQjgSs1cZhXtn8M7ZH4EJWVt2PR31ii0 wKA6DHXIqDgwORtWTFVSVVP+csHt6qsNtGPdMg4/akK1PrT0XLgDj/7vvcfr7Wsm3jsY jb5Cx5C1IsjM/YNmnPquRbsVRoUaaxO5V7r7RNugAtS9AL9EUapqHo5wzPgqNAFQwmQQ nxydksIw2k2ZG+mjphnLVjUrlJZN5SUkXl3fb/jKcLZxHkLI+7bG04sWSVxHJWEzhi9N cEZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@grimler.se header.s=default header.b=E6DKhDC+; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dc24si2645012edb.508.2020.10.06.08.26.07; Tue, 06 Oct 2020 08:26:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@grimler.se header.s=default header.b=E6DKhDC+; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726164AbgJFPZ5 (ORCPT + 99 others); Tue, 6 Oct 2020 11:25:57 -0400 Received: from h04mx15.reliablemail.org ([185.76.67.208]:11511 "EHLO h04mx15.reliablemail.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbgJFPZ4 (ORCPT ); Tue, 6 Oct 2020 11:25:56 -0400 X-Greylist: delayed 362 seconds by postgrey-1.27 at vger.kernel.org; Tue, 06 Oct 2020 11:25:55 EDT X-Halon-Out: 61426548-07e7-11eb-ae9c-016faf663c66 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=grimler.se; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MpgtNIMYLlL4bB1Pb4In1NFBTR9GjbE0/qeHo4XPlDo=; b=E6DKhDC+rj92zygarEn5qPPl19 eyXiaab/lT+vWoZJSCI6BDwFmMfy2SlH1RRDKAj6ICEyDWtgCOytYHc0MRkmX2HDsDDxJr8wIOUFx f8/xBXsL39m8WZTkVY9C0bNiONKEpmPFt/RyOhdLNQlDLdbreNK0h7sRJbebZUpJUQap5BKWmvJlS 6bvuhlefpNAdwLmAr8yKGAA8PGFjFdmIVlKmK2PiF7MVxjOQxJErGPkIS8pWQvOAwaKk6hrBWxEHk u1eGlGRQrMf8UlDS4ZDifeHg/8fZ5C2lW2nG8Qwz9KzNsabcacXjMkKefycghDEu8daM5E7df04rZ dAFK6Wlw==; From: Henrik Grimler To: linux-bluetooth@vger.kernel.org Cc: Henrik Grimler Subject: [PATCH BlueZ v2] tools: fix forgotten index->mgmt_index renaming in btmgmt.c Date: Tue, 6 Oct 2020 17:19:43 +0200 Message-Id: <20201006151943.125484-1-henrik@grimler.se> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpsrv07.misshosting.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - grimler.se X-Get-Message-Sender-Via: cpsrv07.misshosting.com: authenticated_id: henrik@grimler.se X-Authenticated-Sender: cpsrv07.misshosting.com: henrik@grimler.se X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Commit 6523d168a7c1 ("tools/btmgmt: Port to use bt_shell") seem to have missed this. When trying to compile bluez I get: ``` tools/btmgmt.c:1229:34: warning: implicitly declaring library function 'index' \ with type 'char *(const char *, int)' [-Wimplicit-function-declaration] config_info_rsp, UINT_TO_PTR(index), NULL)) { ^ tools/btmgmt.c:1229:34: note: include the header or explicitly \ provide a declaration for 'index' [...] aarch64-linux-android-ld: tools/btmgmt.o: in function `cmd_config': btmgmt.c:(.text+0x544): undefined reference to `index' aarch64-linux-android-ld: btmgmt.c:(.text+0x548): undefined reference to `index' ``` Probably only happens on system (like android) where the obsolete index function does not exist. --- Changes in v2: - Update commit message to make lint bot happy tools/btmgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/btmgmt.c b/tools/btmgmt.c index b0b837d34..228f94efa 100644 --- a/tools/btmgmt.c +++ b/tools/btmgmt.c @@ -1213,7 +1213,7 @@ static void cmd_config(int argc, char **argv) } if (!mgmt_send(mgmt, MGMT_OP_READ_CONFIG_INFO, mgmt_index, 0, NULL, - config_info_rsp, UINT_TO_PTR(index), NULL)) { + config_info_rsp, UINT_TO_PTR(mgmt_index), NULL)) { error("Unable to send read_config_info cmd"); return bt_shell_noninteractive_quit(EXIT_FAILURE); } -- 2.28.0