Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3374889pxu; Mon, 19 Oct 2020 10:26:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6t4gMxQg8D4BrckaC12HXwA4jqvZJrK0J9ZEmiCoyueqBB/FVxuMdpKLtUhTUzCLeGEV3 X-Received: by 2002:a05:6402:6d0:: with SMTP id n16mr880147edy.133.1603128392737; Mon, 19 Oct 2020 10:26:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603128392; cv=none; d=google.com; s=arc-20160816; b=gfUA9nRn5462UyTlB3LiKGpJdiPVGnm+t77yb+UamBz7GPuHZ/QaVW/LLkHCgBkml1 WXCPOhMi7+lZOjfH9O4BCVrK2ReoYz0t4C0dXtGDEJBdk/U6xZYOYJ3xL29tjG6B06Q2 802I/szOtVuSMXlp/xVDkI/Eutk34AAiQEmWXVVX8bsMjCX5i3inHWGqy531QvCQBiX8 7MhQ7K9JDxsb7Ik/7/au0PH4KSHNgymfg2DQVYqfRcsyjJrPSqdooLAnpK5hmhXwTZnz T1gbYLN+SVvz87eg7xOtdI2LAjl0S4lK0d/mj6IENdq/KCtMSlMHK9Zc7I5FSGEou9ou xP3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=rdSQv0WqI8XOqcIsRkumiryUop8LX5S6l8HxLs9v6HM=; b=geH/GqGChSgaUQJrWMVNCk3mu1JcPW+JzmjFGmxIU37Ix5J8ESsPMenb7fCyRPE9Jy NgMAHmUSwegtvreDGFOPQ7Kl75m66DFn5ZGC4bNs4EVsBtML9l1SlVoHFsNopw5hlZj1 IhJ3dgjM/4Nf5RbDh0Lx7uhHcSSB896Eo3q9PJQwUBAS5XUuOoTjYoGh5t4hesRP9odK cnTBL3TE6qA6cTwr6zs5Hmx6QaQtyfYYSXidC5hsOTbC3IbZvU4F4Ih3YCazt/ryaEVf m6UQC/vjp237HYGlqWNbwGQ0A4OZNUEMZQEdftZhoFBHaJ1WMyNCsxOPeafwRJcR+/Tr IJyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JpAZhP0c; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d1si421287ejj.113.2020.10.19.10.25.57; Mon, 19 Oct 2020 10:26:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JpAZhP0c; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725887AbgJSRZd (ORCPT + 99 others); Mon, 19 Oct 2020 13:25:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725952AbgJSRZd (ORCPT ); Mon, 19 Oct 2020 13:25:33 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1659CC0613D0 for ; Mon, 19 Oct 2020 10:25:33 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id bf6so112404plb.4 for ; Mon, 19 Oct 2020 10:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=rdSQv0WqI8XOqcIsRkumiryUop8LX5S6l8HxLs9v6HM=; b=JpAZhP0cOQ0EvgO3bUuJg+8NtAUxG31mgTDoz29/fG1Z0gT8IWvZpt08F2pe7Pr85T LEG8tvjRMx9HobVcT2md3rfVRiXbEvAVscuefz1ifk5DUp8/T5lEjZ0MxSyRtqr9RbWD P3LQmL1RqDFtHbAwVByjPw2PwK869aJ5xyTgHeBhO+WhBvzTOi10lw0yXzHpM8IRCi00 mklhJLoZ4j+PDqWMULRJHNoTePkbKC7XWwg2ApH2AmDSTKX3koQpDwWvBeoCTBvQfDEy Mr+OgDooQ1Gw2j7/imI5g7qs7qcuYJBpKtiAuJHtBuv8J2493uwtKPluU8CqjqHznPiw QJyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rdSQv0WqI8XOqcIsRkumiryUop8LX5S6l8HxLs9v6HM=; b=hpiHSoQBp3k/gKp/IfjFVhEsHoXQ4GpS8A+fTA66ZblNL5+7nh4t9MRTqMm7PAQxLU T7FKBe9LyfKeJlg0LQlubDx1WzYdZAvG3XY4fyhOE2EJ/ZVvQ2gVPMfilfiWmlmyqTaq 2QlkkKoHXwvGvwvG+rWo2tFub8A4iEIyyXapy2cyOzZvqCq3PKZurkKueBTQmgXDnDJZ GakoJsQrRZMA1WLIZ8g01u7e5LPQxlfoZDlajODfznGBKmBRlTPllNqj1qpTqC6R5PIh nAdVsmbMzp+eVo+kCf+Ec4INKsa68BMCYum5AeH2buxoI3BTGqq2ub8F1RfmkvzHAKdr WIZQ== X-Gm-Message-State: AOAM532hNtEMyvAcPLnkQZv8PJcAkJbAeyE6ijcY02lw4Q6ts3qg3kwE 9MEXkGDOCnXXvFoINid5j8N3Qp3iE6/Fuw== X-Received: by 2002:a17:902:a9ca:b029:d5:dc92:9608 with SMTP id b10-20020a170902a9cab02900d5dc929608mr786360plr.41.1603128332291; Mon, 19 Oct 2020 10:25:32 -0700 (PDT) Received: from localhost.localdomain (c-71-56-157-77.hsd1.or.comcast.net. [71.56.157.77]) by smtp.gmail.com with ESMTPSA id h6sm370103pfk.212.2020.10.19.10.25.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 10:25:31 -0700 (PDT) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH v2 2/2] Bluetooth: A2MP: Fix not setting request ID Date: Mon, 19 Oct 2020 10:25:29 -0700 Message-Id: <20201019172529.1179996-2-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201019172529.1179996-1-luiz.dentz@gmail.com> References: <20201019172529.1179996-1-luiz.dentz@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Luiz Augusto von Dentz This fixes not resetting of the request ID when sending A2MP_GETAMPASSOC_RSP. Fixes: Bluetooth: A2MP: Fix not initializing all members Signed-off-by: Luiz Augusto von Dentz --- net/bluetooth/a2mp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c index da7fd7c8c2dc..7a1e0b785f45 100644 --- a/net/bluetooth/a2mp.c +++ b/net/bluetooth/a2mp.c @@ -381,10 +381,11 @@ static int a2mp_getampassoc_req(struct amp_mgr *mgr, struct sk_buff *skb, hdev = hci_dev_get(req->id); if (!hdev || hdev->amp_type == AMP_TYPE_BREDR || tmp) { struct a2mp_amp_assoc_rsp rsp; - rsp.id = req->id; memset(&rsp, 0, sizeof(rsp)); + rsp.id = req->id; + if (tmp) { rsp.status = A2MP_STATUS_COLLISION_OCCURED; amp_mgr_put(tmp); -- 2.26.2