Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201001230152.2422908-1-danielwinkler@google.com> <20201001155738.Bluez.v4.1.Ifaa96e71a871158e5d9d454073b2b6846eae339f@changeid>
In-Reply-To: <20201001155738.Bluez.v4.1.Ifaa96e71a871158e5d9d454073b2b6846eae339f@changeid>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 27 Oct 2020 14:59:38 -0700
Message-ID: <CABBYNZLzsZ=rvqHCpQze1ht_LVvj9HL4ecmeqXnev0V-0AkOpw@mail.gmail.com>
Subject: Re: [Bluez PATCH v4 01/10] doc/advertising-api: update API with new interface
To:     Daniel Winkler <danielwinkler@google.com>
Cc:     Luiz Augusto Von Dentz <luiz.von.dentz@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>,
        Sonny Sasaka <sonnysasaka@chromium.org>,
        Alain Michaud <alainm@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Daniel,

On Thu, Oct 1, 2020 at 4:07 PM Daniel Winkler <danielwinkler@google.com> wrote:
>
> This updates the advertising documentation to include the following
> features:
>
> LE Advertising Manager:
> - New SupportedCapabilities property
>
> LE Advertisement:
> - New min/max interval properties
> - New tx power property
>
> Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
> Reviewed-by: Alain Michaud <alainm@chromium.org>
> ---
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>  doc/advertising-api.txt | 50 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
>
> diff --git a/doc/advertising-api.txt b/doc/advertising-api.txt
> index b0565eab2..3215a52f7 100644
> --- a/doc/advertising-api.txt
> +++ b/doc/advertising-api.txt
> @@ -138,6 +138,33 @@ Properties string Type
>                                         "2M"
>                                         "Coded"
>
> +               uint32 MinInterval
> +
> +                       Minimum advertising interval to be used by the
> +                       advertising set, in .625 millisecond slots.
> +                       Time = N * .625 ms, where N has range
> +                       [0x000020, 0xFFFFFF]. If the provided MinInterval is
> +                       larger than the provided MaxInterval, the registration
> +                       will return failure.
> +
> +               uint32 MaxInterval
> +
> +                       Maximum advertising interval to be used by the
> +                       advertising set, in .625 millisecond slots.
> +                       Time = N * .625 ms, where N has range
> +                       [0x000020, 0xFFFFFF]. If the provided MinInterval is
> +                       larger than the provided MaxInterval, the registration
> +                       will return failure.
> +
> +               int16 TxPower
> +
> +                       Requested transmission power of this advertising set.
> +                       The provided value is used only if the "CanSetTxPower"
> +                       feature is enabled on the Advertising Manager. The
> +                       provided value must be in range [-127 to +20], where
> +                       units are in dBm.
> +
> +
>  LE Advertising Manager hierarchy
>  ================================
>
> @@ -209,3 +236,26 @@ Properties byte ActiveInstances
>                         Possible values: "1M"
>                                          "2M"
>                                          "Coded"
> +
> +               dict SupportedCapabilities
> +
> +                       Enumerates Advertising-related controller capabilities
> +                       useful to the client.
> +
> +                       Possible Values:
> +
> +                               byte MaxAdvLen
> +
> +                                       Max advertising data length
> +
> +                               byte MaxScnRspLen
> +
> +                                       Max advertising scan response length
> +
> +                               int16 MinTxPower
> +
> +                                       Min advertising tx power (dBm)
> +
> +                               int16 MaxTxPower
> +
> +                                       Max advertising tx power (dBm)
> --
> 2.28.0.709.gb0816b6eb0-goog

Please mark these as experimental for now, other than that it looks good to me.


-- 
Luiz Augusto von Dentz