Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201103073032.4532-1-sathish.narasimman@intel.com>
In-Reply-To: <20201103073032.4532-1-sathish.narasimman@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 4 Nov 2020 13:03:17 -0800
Message-ID: <CABBYNZKYVF+gXS91-DSs8yh6DGcNz6YL0x3Aj8moXoBEzV8pdQ@mail.gmail.com>
Subject: Re: [Bluez PATCH] profile: GOEP Set IMTU to 32k
To:     Sathish Narasimman <nsathish41@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Chethan T N <chethan.tumkur.narayan@intel.com>,
        ravishankar.srivatsa@intel.com,
        Sathish Narasimman <sathish.narasimman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Sathish,

On Mon, Nov 2, 2020 at 11:30 PM Sathish Narasimman <nsathish41@gmail.com> wrote:
>
> OPP-RX Throughput is low Due to Low MTU value in case of OBEX
> over L2CAP. Changing the default L2CAP MTU from 672 to 32767.
>
> Signed-off-by: Sathish Narasimman <sathish.narasimman@intel.com>
> ---
>  src/profile.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/src/profile.c b/src/profile.c
> index 5e460b639..99a5e1a4a 100644
> --- a/src/profile.c
> +++ b/src/profile.c
> @@ -41,6 +41,8 @@
>  #include "profile.h"
>  #include "service.h"
>
> +#define BTRX_MTU               32767
> +
>  #define DUN_DEFAULT_CHANNEL    1
>  #define SPP_DEFAULT_CHANNEL    3
>  #define HSP_HS_DEFAULT_CHANNEL 6
> @@ -1358,6 +1360,11 @@ static uint32_t ext_start_servers(struct ext_profile *ext,
>                         l2cap->adapter = btd_adapter_ref(adapter);
>                         ext->servers = g_slist_append(ext->servers, l2cap);
>                         DBG("%s listening on PSM %u", ext->name, psm);
> +                       if (g_strcmp0(ext->name, "Object Push") == 0) {
> +                               if (!bt_io_set(io, NULL, BT_IO_OPT_IMTU, BTRX_MTU,
> +                                   BT_IO_OPT_INVALID))
> +                                       DBG("ERROR bt_io_set Unable to set MTU");
> +                       }
>                 }
>         }
>
> --
> 2.17.1

Perhaps it would be better to have the MTU added to RegisterProfile
options so any user of this API can set the Input MTU.

-- 
Luiz Augusto von Dentz