Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4053892pxb;
        Tue, 17 Nov 2020 10:03:38 -0800 (PST)
X-Google-Smtp-Source: ABdhPJw1GP9tUqYNL8e4HL0rMIwyN3tBIdy1QsuYPY8g6rvjl72Tk2bH3tYkHG0qTfehGjZLYTwx
X-Received: by 2002:a17:906:5e02:: with SMTP id n2mr19349329eju.295.1605636218100;
        Tue, 17 Nov 2020 10:03:38 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605636218; cv=none;
        d=google.com; s=arc-20160816;
        b=E3egQw3GrR1O3URx/RCZj2yIul5EfEl1FSi1GiSbxqxbVeyIbROy5l4b9nLzdxew+a
         N/JFnMu0bsa9qqCjbBC1lDfog5g6beapiDHvADQeN1sJEe5n7ri/A8Nl7v5Txpbtd7VX
         YdWxBU6ZcI4WCZ924FI9W6e74NC48z+ms2lH98U1KEKKasExYb/z8kCYG2Ebyc1g2sSI
         XqlSjVvKskps/SjBgVs22fABGW3Brw806Kkp52rlvCu9JyDtJitnJo2RB6DUUl6LwD7e
         nBmqzGYU2RMZhJZJd+rF2EFOf5F75/XLPhzDnuL8+x9Fkx7bfQntHAbrAyFNAM4v4pM9
         dTPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :user-agent:references:in-reply-to:date:cc:to:from:subject
         :message-id;
        bh=GfFH3wQ1GSnW/fLg9crDJNLiJVVssgD0nYzGIkBOMNs=;
        b=ciFkNL+PMfDUV7OpV2R8F2a3cXBcQ+tZTTyq3TKo1M9itRuiMTc9swdOnqqzjlU3j/
         JTsQx4vXRKeV5gVjAlQOn8XN0jb1FIuxTZ3cReFO/IFLjQJBW7i3c0YNVF5vL+63W/KJ
         ug33fACjypZ6ppukxswd8IjWGojdkGgjmtFxJ6SSbJ4IJmXRBcrVeTD51klGdOOK2pwL
         ev8L/0kqyNJ9pwDnMPN8nQ6O6vZ8CwJCTabZdeSL43ucdJSDR+d/5FAQ5n7hCWMQRB6F
         VAL7J1bNbJ7JPV6gRq1GHQ2nZgxfSFitndUTcsjE5fIy36AjcCsmZ9YGNCwUpaVHiqow
         4HfA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org
Return-Path: <linux-bluetooth-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id d8si14614029edm.404.2020.11.17.10.02.56;
        Tue, 17 Nov 2020 10:03:38 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730156AbgKQSBs (ORCPT <rfc822;maitysanchayan@gmail.com>
        + 99 others); Tue, 17 Nov 2020 13:01:48 -0500
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:54035 "EHLO
        relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728424AbgKQSBs (ORCPT
        <rfc822;linux-bluetooth@vger.kernel.org>);
        Tue, 17 Nov 2020 13:01:48 -0500
X-Originating-IP: 82.255.60.242
Received: from [192.168.0.28] (lns-bzn-39-82-255-60-242.adsl.proxad.net [82.255.60.242])
        (Authenticated sender: hadess@hadess.net)
        by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id B7C2C60003;
        Tue, 17 Nov 2020 18:01:45 +0000 (UTC)
Message-ID: <1273e316b9ec06061a1065c04521ae91ab379af1.camel@hadess.net>
Subject: Re: [PATCH BlueZ v2 7/7] battery: Implement Battery Provider API
From:   Bastien Nocera <hadess@hadess.net>
To:     Sonny Sasaka <sonnysasaka@chromium.org>,
        linux-bluetooth@vger.kernel.org
Cc:     Miao-chen Chou <mcchou@chromium.org>
Date:   Tue, 17 Nov 2020 19:01:45 +0100
In-Reply-To: <aa1c080e8a7813299e6a093608211684e074e427.camel@hadess.net>
References: <20201111011745.2016-1-sonnysasaka@chromium.org>
         <20201111011745.2016-7-sonnysasaka@chromium.org>
         <aa1c080e8a7813299e6a093608211684e074e427.camel@hadess.net>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.1 (3.38.1-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

On Tue, 2020-11-17 at 11:51 +0100, Bastien Nocera wrote:
> <
> <snip> didn't review the code in depth, but, having written this
> mechanism
> for Bluetooth battery reporting, I think that this is the right way
> to
> go to allow daemons like pulseaudio to report battery status.

It would also be useful to know what external components, or internal
plugins you expect to feed this API.

Apparently HSP/HFP, for example, provide more information that what can
be expressed with the Battery1 API, whether it is charging or not, or
whether a battery level is unknown, etc.

So I would say that, even if the current battery API is extended, we
need to make sure that the D-Bus API to feed new data is extensible
enough to allow new properties, and they don't need to be added
separately to org.bluez.BatteryProvider1 or org.bluez.Battery1.