Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp374412pxb; Thu, 19 Nov 2020 03:39:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqIXLC8KioVZJ4pDA/bIeJ7XY4mndgkofT/yJ8yEEqB5ezeUc4rst5UEaIWk9W6yYg/6hf X-Received: by 2002:a05:6402:2208:: with SMTP id cq8mr11710214edb.182.1605785987063; Thu, 19 Nov 2020 03:39:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605785987; cv=none; d=google.com; s=arc-20160816; b=vYJhPlE/MIYGwvypTEVdIUUw+/u4muMg57EUNlleQNwewXR97bHNvBWVDWTVovlct1 kO3UJlscqDhDGP+Y2eS9azqbqUF9m0lZ5aeCH8061ozY9buNDMfMu/IG9AxFsDgj+bbf OIzgTJEMbhRaC9pCd4NLWoEtryFIEHByBUvpWzboAaGLTtC7x03wN1Jj5wfDSnfHRuwF 2CG15HygTOwNQhub3mKbwLRUbdJabnyYD64GSo2RqF/nnWFgkkx2a3tDg9PU36maL3S6 1YXBC6dRbRn3hXAGEuCufrk/hop59EoqHK//HgDKdCZahW6AHth8esi4XuPnNn5J6I4X Ijqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:ironport-sdr :ironport-sdr; bh=7B8D6YHFrDk3kqvBPqTyb1M5WAynDIcQgGzKdvsRnQw=; b=Jt5KoxZn4sQQSBP4Kqd9x9vKaOmkyVhQ6Ia0ZyVuZeUCEQEuGRY3sgX1l7iteWrJw5 Okha75eZ+DkzxfjQlD6s95gHCT99d93MzEtlA2dYgRTZDCrXgRaff7JwT2Wl91Qwux0a TmtzK/nbYMwPKi5OgZFpMKXAygESjD0R9XuWhis60wS5fm2D18B2KX/+v20/VCs76MGu E2oW1Nb7QD95PXMPtEqknvZ2RslV440VdMHU2Xhk6vrwvJ0VpfOtezlQRzi3h1LuUaDu RHOC6W86I4n5SmBqAB77jht4zJJuhQ7rGjwQfPdPV9vbavYILdO45yUfM/YFCbOz4AGG 8AsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u21si1097404ejt.431.2020.11.19.03.39.14; Thu, 19 Nov 2020 03:39:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726712AbgKSLhv (ORCPT + 99 others); Thu, 19 Nov 2020 06:37:51 -0500 Received: from mga11.intel.com ([192.55.52.93]:21909 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726474AbgKSLhv (ORCPT ); Thu, 19 Nov 2020 06:37:51 -0500 IronPort-SDR: 21MoNy75/IB/mRSuM/DibWCl9E11Ye3tTjLBMsRG26LDut06NdsLb8dIaTxizmrrKZN/nsaxtk yPRyC+we3Saw== X-IronPort-AV: E=McAfee;i="6000,8403,9809"; a="167763745" X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208";a="167763745" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2020 03:37:50 -0800 IronPort-SDR: aa67KEz22ElSRD/NbX/k9ioxX18IP715rzll4ntweAe075ZNf5TnUmjw0rKWFY+a5lwazN72Iv wKhHbFeBdvmQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208";a="325950027" Received: from intel-lenovo-legion-y540-15irh-pg0.iind.intel.com ([10.224.186.95]) by orsmga003.jf.intel.com with ESMTP; 19 Nov 2020 03:37:48 -0800 From: Kiran K To: linux-bluetooth@vger.kernel.org Cc: ravishankar.srivatsa@intel.com, chethan.tumkur.narayan@intel.com, sathish.narasimman@intel.com, Kiran K Subject: [PATCH v8 1/5] Bluetooth: btintel: Fix endianness issue for TLV version information Date: Thu, 19 Nov 2020 17:09:39 +0530 Message-Id: <20201119113943.13839-1-kiran.k@intel.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org do __le32_to_cpu to tlv data fields to make sure driver runs correctly when running on big endian system. Signed-off-by: Kiran K Reviewed-by: Chethan T N Reviewed-by: Srivatsa Ravishankar --- drivers/bluetooth/btintel.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index 88ce5f0ffc4b..41ff2071d7ef 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -437,31 +437,38 @@ int btintel_read_version_tlv(struct hci_dev *hdev, struct intel_version_tlv *ver tlv = (struct intel_tlv *)skb->data; switch (tlv->type) { case INTEL_TLV_CNVI_TOP: - version->cnvi_top = get_unaligned_le32(tlv->val); + version->cnvi_top = + __le32_to_cpu(get_unaligned_le32(tlv->val)); break; case INTEL_TLV_CNVR_TOP: - version->cnvr_top = get_unaligned_le32(tlv->val); + version->cnvr_top = + __le32_to_cpu(get_unaligned_le32(tlv->val)); break; case INTEL_TLV_CNVI_BT: - version->cnvi_bt = get_unaligned_le32(tlv->val); + version->cnvi_bt = + __le32_to_cpu(get_unaligned_le32(tlv->val)); break; case INTEL_TLV_CNVR_BT: - version->cnvr_bt = get_unaligned_le32(tlv->val); + version->cnvr_bt = + __le32_to_cpu(get_unaligned_le32(tlv->val)); break; case INTEL_TLV_DEV_REV_ID: - version->dev_rev_id = get_unaligned_le16(tlv->val); + version->dev_rev_id = + __le16_to_cpu(get_unaligned_le16(tlv->val)); break; case INTEL_TLV_IMAGE_TYPE: version->img_type = tlv->val[0]; break; case INTEL_TLV_TIME_STAMP: - version->timestamp = get_unaligned_le16(tlv->val); + version->timestamp = + __le16_to_cpu(get_unaligned_le16(tlv->val)); break; case INTEL_TLV_BUILD_TYPE: version->build_type = tlv->val[0]; break; case INTEL_TLV_BUILD_NUM: - version->build_num = get_unaligned_le32(tlv->val); + version->build_num = + __le32_to_cpu(get_unaligned_le32(tlv->val)); break; case INTEL_TLV_SECURE_BOOT: version->secure_boot = tlv->val[0]; -- 2.17.1