Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>
Cc:     BlueZ development <linux-bluetooth@vger.kernel.org>
From:   Heiner Kallweit <hkallweit1@gmail.com>
Subject: Updated fw versions ignored for Intel devices?
Message-ID: <0011e099-4ab0-4705-de1e-cb03953f11ef@gmail.com>
Date:   Thu, 19 Nov 2020 23:05:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

In btusb.c we have the following code. I interpret this in a way
that once firmware was loaded the driver will never check for
updated firmware.
Shouldn't the driver always read the firmware file available on
the system and check its version against the firmware version
the device has (and apply it if it's newer)?
But maybe I miss something ..

bt_dev_info(hdev, "read Intel version: %02x%02x%02x%02x%02x%02x%02x%02x%02x",
	    ver.hw_platform, ver.hw_variant, ver.hw_revision,
	    ver.fw_variant,  ver.fw_revision, ver.fw_build_num,
	    ver.fw_build_ww, ver.fw_build_yy, ver.fw_patch_num);

/* fw_patch_num indicates the version of patch the device currently
 * have. If there is no patch data in the device, it is always 0x00.
 * So, if it is other than 0x00, no need to patch the device again.
 */
if (ver.fw_patch_num) {
	bt_dev_info(hdev, "Intel device is already patched. "
		    "patch num: %02x", ver.fw_patch_num);
	goto complete;
}