Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp770710pxu; Mon, 23 Nov 2020 03:52:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkXp9ytKkCAVzvIlTkxqTPrJCXQzd9bPwvj+kSOfaPIoFTNyJYGTIAXnsFLmJG2C9/yZY2 X-Received: by 2002:a17:906:28d4:: with SMTP id p20mr4339575ejd.322.1606132356453; Mon, 23 Nov 2020 03:52:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606132356; cv=none; d=google.com; s=arc-20160816; b=cEXAGZYds3GXBmzWhybR9phhguHzyktnnVCJkPXu5blkrqSemkWMJF/x/nNafNQH1Y 8FRGuq1WyL9594ZOKvGAK6J9CWD5gRV9C0uWAVlr/jU2lxuFxb8yXu56gWVtjGavxJ1V 5zWsewtIFKdx3NriRhVEvBPxq0jD0WX2lL7kTu9KAg0TsEaekYd0eH1DnrUnVuDHq4kn NVnToC2KzrJEXkt2/RicO6IMJxf01kdZVpUPGH07GDXqZQEr0bwqYtngWGpz88qNhztx WnON7i7hhzMS5Dj09jeB6oVBK1APUUcojMXZtwer3lHeLCdW/mn3CqW4xDTGBKMKcoEP lMcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=jEHsgIoHMxbWstKxNPSKvZIp3TttyMbN+UuBrnyeMdE=; b=dj4/EsHdbUxIIdwYVTvZCKmMPVUr9s34boTrYFh1sb86CRMjPznpN1VeEId8riv3J9 2tXxHKW4YSLsYWCvh4SpawQ/XjNYILehEJb+WvnxOzCyXpuwnRCGOltZbW//UNO72lUk cqfhkSq+EEzVKa4vUk1FVJDpOHszXz6w/OZ/r8uyFZgUr8IknRVIis0aIKefdrLmHk7F FrGudXD7nNT14pB7NzQq/d2p8WAQTtgljGE1laIqpFxOoMnKUNSTkC1AbWndICQEXHk0 v9LlWWiSZICmTlk08baWioad3dva8U5mCUaGykPNPSxLfkA4O9h+1dsBPrMsqX2h+y5W NSwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l4si6577065edt.49.2020.11.23.03.52.12; Mon, 23 Nov 2020 03:52:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728978AbgKWLvA (ORCPT + 99 others); Mon, 23 Nov 2020 06:51:00 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:37654 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728976AbgKWLvA (ORCPT ); Mon, 23 Nov 2020 06:51:00 -0500 Received: from marcel-macbook.holtmann.net (unknown [37.83.193.87]) by mail.holtmann.org (Postfix) with ESMTPSA id AA0D9CECCF; Mon, 23 Nov 2020 12:58:10 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.20.0.2.21\)) Subject: Re: [PATCH] Bluetooth: btusb: Add the missed release_firmware() in btusb_mtk_setup_firmware() From: Marcel Holtmann In-Reply-To: <20201117025917.168761-1-jingxiangfeng@huawei.com> Date: Mon, 23 Nov 2020 12:50:58 +0100 Cc: Johan Hedberg , Mark-YW.Chen@mediatek.com, sean.wang@mediatek.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <20201117025917.168761-1-jingxiangfeng@huawei.com> To: Jing Xiangfeng X-Mailer: Apple Mail (2.3654.20.0.2.21) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Jing, > btusb_mtk_setup_firmware() misses to call release_firmware() in an error > path. Jump to err_release_fw to fix it. > > Fixes: f645125711c8 ("Bluetooth: btusb: fix up firmware download sequence") > Signed-off-by: Jing Xiangfeng > --- > drivers/bluetooth/btusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel