Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Kwkdh89c5tj2TW4esmtdlL64vi5lyoTRIMxVK/1lz0NCKRPEhHZuNI+P6QHvEnxWzwd78BKfhT
 dwrGm4mSGLTQ==
IronPort-SDR: 7luJT234VfTuZVirhgnFdmFTtYjBEAtxXrBw5iFYdSFVg9LdOvZtfvkc65ni4xTcHSbt4QLGO6
 ml4/T4Dfk4ug==
From:   "K, Kiran" <kiran.k@intel.com>
To:     Marcel Holtmann <marcel@holtmann.org>,
        Heiner Kallweit <hkallweit1@gmail.com>
CC:     Johan Hedberg <johan.hedberg@gmail.com>,
        BlueZ development <linux-bluetooth@vger.kernel.org>,
        "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
        "Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>
Subject: RE: Updated fw versions ignored for Intel devices?
Thread-Topic: Updated fw versions ignored for Intel devices?
Thread-Index: AQHWvsB1fgDvuKgee0Sd1H46GdMnyqnVnI2AgABevJA=
Date:   Mon, 23 Nov 2020 17:24:42 +0000
Message-ID: <BYAPR11MB3141B751152EC960E746D9A9F5FC0@BYAPR11MB3141.namprd11.prod.outlook.com>
References: <0011e099-4ab0-4705-de1e-cb03953f11ef@gmail.com>
 <17CC90CE-CA5F-40B8-8C07-8313A35E944F@holtmann.org>
In-Reply-To: <17CC90CE-CA5F-40B8-8C07-8313A35E944F@holtmann.org>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e792f362-dc26-4b04-d303-08d88fd4aa10
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2020 17:24:42.1013
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Glnim8pXd+CWVLy3rwDd2wwHSHkevalLsSszYF/rCiaW8QGbGrboGV1fDKDHB6Y+KP9MMhY0ChGuaLIafCv9fg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4038
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Marcel, Heiner

> -----Original Message-----
> From: Marcel Holtmann <marcel@holtmann.org>
> Sent: Monday, November 23, 2020 5:08 PM
> To: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Johan Hedberg <johan.hedberg@gmail.com>; BlueZ development <linux-
> bluetooth@vger.kernel.org>
> Subject: Re: Updated fw versions ignored for Intel devices?
>=20
> Hi Heiner,
>=20
> > In btusb.c we have the following code. I interpret this in a way that
> > once firmware was loaded the driver will never check for updated
> > firmware.
> > Shouldn't the driver always read the firmware file available on the
> > system and check its version against the firmware version the device
> > has (and apply it if it's newer)?
> > But maybe I miss something ..

Need to check. If I am correct, the firmware images are encrypted and signe=
d. Need to explore if there are any dependencies to read the firmware versi=
on.
> >
> > bt_dev_info(hdev, "read Intel version:
> %02x%02x%02x%02x%02x%02x%02x%02x%02x",
> > 	    ver.hw_platform, ver.hw_variant, ver.hw_revision,
> > 	    ver.fw_variant,  ver.fw_revision, ver.fw_build_num,
> > 	    ver.fw_build_ww, ver.fw_build_yy, ver.fw_patch_num);
> >
> > /* fw_patch_num indicates the version of patch the device currently
> > * have. If there is no patch data in the device, it is always 0x00.
> > * So, if it is other than 0x00, no need to patch the device again.
> > */
> > if (ver.fw_patch_num) {
> > 	bt_dev_info(hdev, "Intel device is already patched. "
> > 		    "patch num: %02x", ver.fw_patch_num);
> > 	goto complete;
> > }
>=20
> if you reboot it looses its firmware and things start over again.

Reboot doesn't guarantee to load new firmware on all platforms as the power=
 supply to BT adapter will still be intact. Few platforms need power cycle.
>=20
> Regards
>=20
> Marcel

Thanks,
Kiran