Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201029230623.3630069-1-danielwinkler@google.com>
 <20201029160317.Bluez.v6.3.Iabfcf7ec8ac293130a7d903ee8094414256799b3@changeid>
 <263DCED1-D5D0-4ABD-A6C9-5A4ACA45458E@holtmann.org>
In-Reply-To: <263DCED1-D5D0-4ABD-A6C9-5A4ACA45458E@holtmann.org>
From:   Daniel Winkler <danielwinkler@google.com>
Date:   Tue, 24 Nov 2020 10:16:32 -0800
Message-ID: <CAP2xMbstBAHK1Q35VEaeuhdobY6baRyKwcj=u68GDW=WTVmz=w@mail.gmail.com>
Subject: Re: [Bluez PATCH v6 03/10] doc/mgmt-api: Update controller
 capabilities MGMT command in mgmt-api
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
        BlueZ <linux-bluetooth@vger.kernel.org>,
        chromeos-bluetooth-upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Marcel,

As I understand, Luiz accepted this series already. I will upload a
new patch to fix this wording, thanks for catching it!

Best,
Daniel

On Mon, Nov 9, 2020 at 4:49 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Daniel,
>
> > This patch changes Read Security Info MGMT to be called Read Controller
> > Capabilities Command
> >
> > ---
> >
> > Changes in v6: None
> > Changes in v5: None
> > Changes in v4:
> > - mgmt-api: Move Controller Capabilities MGMT doc into new patch
> > - mgmt-api: Tx Power range put into single capabilities entry
> >
> > Changes in v3: None
> > Changes in v2: None
> >
> > doc/mgmt-api.txt | 21 +++++++++++++++------
> > 1 file changed, 15 insertions(+), 6 deletions(-)
> >
> > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> > index 7c899a8fe..1aa43d6c3 100644
> > --- a/doc/mgmt-api.txt
> > +++ b/doc/mgmt-api.txt
> > @@ -3110,19 +3110,19 @@ Set Wideband Speech Command
> >                               Invalid Index
> >
> >
> > -Read Security Information Command
> > -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > +Read Controller Capabilities Command
> > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >
> >       Command Code:           0x0048
> >       Controller Index:       <controller id>
> >       Command Parameters:
> > -     Return Parameters:      Security_Data_Length (2 Octets)
> > -                             Security_Data (0-65535 Octets)
> > +     Return Parameters:      Capabilities_Data_Length (2 Octets)
> > +                             Capabilities_Data (0-65535 Octets)
> >
> > -     This command is used to retrieve the supported security features
> > +     This command is used to retrieve the supported capabilities
> >       by the controller or the host stack.
> >
> > -     The Security_Data_Length and Security_Data parameters provide
> > +     The Capabilities_Data_Length and Capabilities_Data parameters pro=
vide
> >       a list of security settings, features and information. It uses
> >       the same format as EIR_Data, but with the namespace defined here.
> >
> > @@ -3131,6 +3131,7 @@ Read Security Information Command
> >               0x01            Flags
> >               0x02            Max Encryption Key Size (BR/EDR)
> >               0x03            Max Encryption Key Size (LE)
> > +             0x04            Supported Tx Power (LE)
>
> make this =E2=80=9CSupported Min/Max TX Power=E2=80=9D. Otherwise looks g=
ood and ready for Luiz to apply.
>
> Regards
>
> Marcel
>