Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2595420pxu; Sat, 28 Nov 2020 21:20:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJy5FCeK5bnXHC1GX+W/1NNuQrB28muAlMHiDQJlDnRdHQkDy0DjfAamUIOf9EKw7/BpkgW6 X-Received: by 2002:aa7:dc48:: with SMTP id g8mr15468386edu.181.1606627207214; Sat, 28 Nov 2020 21:20:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606627207; cv=none; d=google.com; s=arc-20160816; b=wy+tSZ1xS9QwRHbKU9TaHYVl/8amO2bJSqe4OOInkEEJU1MQYEGh7oT9dd+E4WraNu yaBUt2KSP5KP2ICYCo6yu6fci6GBcogKkdJvjA29FZn8t3bofoGBj6JL8Zk2J4/cYaEe RvNahUry7sIte+HwXsKMsrix0rrCDL6LXRtLuq+FRqEstBJtGqj2p3YqdJ3k3CBkdpST wzIWOYW9VBDwgTzR3r/hAN+hHndarAb4ttv+xOK8T1ElP9tkn80FsfZkfQgt0KKCuM+O 4F9CDcqFCQHeuSxjdOU7DwjTO1wZgvCFd+VZ1ZKOh+0uOD7gK++qrgQB0yoF0XqjTYYn 4/bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=mB5FaZAesAVlkpE1tX3rmx3KXiA/7FHTIFF0pZFdXM0=; b=sJIuVCRBXIYweQ9BJnuEqEL/ZhvCzPJfSGMTcV+7mveABjVuikOqxh1kn0AHVutP8Q 9jy6WyDqV+ubwB8ZnoyuCwSdCZ3ULCTLlB86o9tA3nq2cyWZob43h4ntQ4Z6gJZIctwV htGySiANDx1JxpAEXTbZe53Uo6yYjQWJ0NjZ/onKjPn7AMA+ZdRgskUsBhINdxfrJEOP OoLuuomFP6x9aX3MRTVJboqFVzn61SXCQiKYaMvHMQkooTLxsZOlRkUlxBDZSzBpLZuR eZoj4+zdzuJCmghNaBksOHtyKF2sSWgBilDOQw+wYNKo/td5wvba4ja+ky9CjPlVHsNH 3tyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c27si5730509edj.80.2020.11.28.21.19.43; Sat, 28 Nov 2020 21:20:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725828AbgK2FTZ (ORCPT + 99 others); Sun, 29 Nov 2020 00:19:25 -0500 Received: from mga02.intel.com ([134.134.136.20]:28965 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725616AbgK2FTZ (ORCPT ); Sun, 29 Nov 2020 00:19:25 -0500 IronPort-SDR: S5DoUqn3yy+cmrLVLlFve2zW153s3gJ6Sz9QAAKt2H/rchGkP8cwCfFwUUZoVDJn58OQ8fsdbC eVtfic2jcFXw== X-IronPort-AV: E=McAfee;i="6000,8403,9819"; a="159565827" X-IronPort-AV: E=Sophos;i="5.78,378,1599548400"; d="scan'208";a="159565827" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2020 21:18:45 -0800 IronPort-SDR: HEPtU1eXWfKbhOruL9kFRckyHlbgn/gxCpqyQ2dycbEF7Dzj7JxQGiwKH0iDDa7jp1K4a0krkq TKi150ivv56w== X-IronPort-AV: E=Sophos;i="5.78,378,1599548400"; d="scan'208";a="548573595" Received: from brayanix-mobl1.amr.corp.intel.com (HELO ingas-nuc1.intel.com) ([10.209.42.173]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2020 21:18:44 -0800 From: Inga Stotland To: linux-bluetooth@vger.kernel.org Cc: brian.gix@intel.com, sbrown@ewol.com, Inga Stotland Subject: [PATCH BlueZ] mesh: Fix check for mkdir return value Date: Sat, 28 Nov 2020 21:18:38 -0800 Message-Id: <20201129051838.82091-1-inga.stotland@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org This correctly interprets the return value of mkdir(): 0 for success. --- mesh/keyring.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mesh/keyring.c b/mesh/keyring.c index 1ef4fc3ef..38b0152f7 100644 --- a/mesh/keyring.c +++ b/mesh/keyring.c @@ -51,7 +51,7 @@ bool keyring_put_net_key(struct mesh_node *node, uint16_t net_idx, snprintf(key_file, PATH_MAX, "%s%s", node_path, net_key_dir); - if (!mkdir(key_file, 0755)) + if (mkdir(key_file, 0755) != 0) return false; snprintf(key_file, PATH_MAX, "%s%s/%3.3x", node_path, net_key_dir, @@ -88,7 +88,7 @@ bool keyring_put_app_key(struct mesh_node *node, uint16_t app_idx, snprintf(key_file, PATH_MAX, "%s%s", node_path, app_key_dir); - if (!mkdir(key_file, 0755)) + if (mkdir(key_file, 0755) != 0) return false; snprintf(key_file, PATH_MAX, "%s%s/%3.3x", node_path, app_key_dir, @@ -207,7 +207,7 @@ bool keyring_put_remote_dev_key(struct mesh_node *node, uint16_t unicast, snprintf(key_file, PATH_MAX, "%s%s", node_path, dev_key_dir); - if (!mkdir(key_file, 0755)) + if (mkdir(key_file, 0755) != 0) return false; for (i = 0; i < count; i++) { -- 2.26.2