Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201124224658.32605-1-rpigott@berkeley.edu> <5fbd9701.1c69fb81.12fae.4010@mx.google.com>
 <CABBYNZ+PsG_8E_2j4_p7Qp==MyXKNnPOH=dGJc4T7wh18BNKvQ@mail.gmail.com>
In-Reply-To: <CABBYNZ+PsG_8E_2j4_p7Qp==MyXKNnPOH=dGJc4T7wh18BNKvQ@mail.gmail.com>
From:   Alain Michaud <alainmichaud@google.com>
Date:   Tue, 1 Dec 2020 15:33:27 -0500
Message-ID: <CALWDO_Ug-VzXmrTOUmMKgQSqqVx-b_L5rekwnv53d4ynjzyfYg@mail.gmail.com>
Subject: Re: [BlueZ] main.conf: use correct key for BREDR configuration
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Ronan Pigott <rpigott314@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Luiz/Ronan,

This appears to have been an incorrect fix since
parse_mode_config(config, "BREDR", params, ARRAY_SIZE(params)); will
attempt to read from the BREDR section.  My suggestion would be to
update the group table entry instead:

static const struct group_table {
const char *name;
const char **options;
} valid_groups[] = {
{ "General", supported_options },
{ "BREDR", br_options },               //<------
{ "LE", le_options },
{ "Policy", policy_options },
{ "GATT", gatt_options },
{ "AVDTP", avdtp_options },
{ }
};

Thanks,
Alain


On Tue, Nov 24, 2020 at 8:21 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Ronan,
>
> On Tue, Nov 24, 2020 at 4:07 PM <bluez.test.bot@gmail.com> wrote:
> >
> > This is automated email and please do not reply to this email!
> >
> > Dear submitter,
> >
> > Thank you for submitting the patches to the linux bluetooth mailing list.
> > This is a CI test results with your patch series:
> > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=390539
> >
> > ---Test result---
> >
> > ##############################
> > Test: CheckPatch - PASS
> >
> > ##############################
> > Test: CheckGitLint - PASS
> >
> > ##############################
> > Test: CheckBuild - PASS
> >
> > ##############################
> > Test: MakeCheck - PASS
> >
> >
> >
> > ---
> > Regards,
> > Linux Bluetooth
>
> Applied, thanks.
>
>
> --
> Luiz Augusto von Dentz