Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CALWDO_Ug-VzXmrTOUmMKgQSqqVx-b_L5rekwnv53d4ynjzyfYg@mail.gmail.com>
 <C7HTF3EX487A.12XRHXZKFSF76@rxps>
In-Reply-To: <C7HTF3EX487A.12XRHXZKFSF76@rxps>
From:   Alain Michaud <alainmichaud@google.com>
Date:   Tue, 1 Dec 2020 18:03:18 -0500
Message-ID: <CALWDO_XbKaLVsfTmkOU56-xtad7RAFAVnGRux_Ls40qDzF-yFg@mail.gmail.com>
Subject: Re: [BlueZ] main.conf: use correct key for BREDR configuration
To:     Ronan Pigott <rpigott314@gmail.com>
Cc:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

I likely won't get to it for a little while, but if someone will be
fixing this, we also noticed this issue while reviewing the related
patch:

{ "PageTimeout",
&btd_opts.defaults.br.page_timeout,
sizeof(btd_opts.defaults.br.page_scan_win), //<-- this should also be
page_timeout rather than page_scan_win
0x0001,
0xFFFF},

Thanks!
Alain

On Tue, Dec 1, 2020 at 5:53 PM Ronan Pigott <rpigott314@gmail.com> wrote:
>
> On Tue Dec 1, 2020 at 8:33 AM MST, Alain Michaud wrote:
> > Hi Luiz/Ronan,
> >
> > This appears to have been an incorrect fix since
> > parse_mode_config(config, "BREDR", params, ARRAY_SIZE(params)); will
> > attempt to read from the BREDR section. My suggestion would be to
> > update the group table entry instead:
>
> Oh, that's right. Whoops.
>
> Updating the group table sounds good to me.