Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CALWDO_Ug-VzXmrTOUmMKgQSqqVx-b_L5rekwnv53d4ynjzyfYg@mail.gmail.com>
 <C7HTF3EX487A.12XRHXZKFSF76@rxps> <CALWDO_XbKaLVsfTmkOU56-xtad7RAFAVnGRux_Ls40qDzF-yFg@mail.gmail.com>
In-Reply-To: <CALWDO_XbKaLVsfTmkOU56-xtad7RAFAVnGRux_Ls40qDzF-yFg@mail.gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 1 Dec 2020 15:13:22 -0800
Message-ID: <CABBYNZLN+kGfkhBeANmchjQcEmOTE7DBhZxuJ0mh=DLp-S+Ncg@mail.gmail.com>
Subject: Re: [BlueZ] main.conf: use correct key for BREDR configuration
To:     Alain Michaud <alainmichaud@google.com>
Cc:     Ronan Pigott <rpigott314@gmail.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Alain,

On Tue, Dec 1, 2020 at 3:03 PM Alain Michaud <alainmichaud@google.com> wrote:
>
> I likely won't get to it for a little while, but if someone will be
> fixing this, we also noticed this issue while reviewing the related
> patch:
>
> { "PageTimeout",
> &btd_opts.defaults.br.page_timeout,
> sizeof(btd_opts.defaults.br.page_scan_win), //<-- this should also be
> page_timeout rather than page_scan_win
> 0x0001,
> 0xFFFF},

Nice catch:

https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=a37d53db9ae7d21a8f812925303d767d3f03e597

> Thanks!
> Alain
>
> On Tue, Dec 1, 2020 at 5:53 PM Ronan Pigott <rpigott314@gmail.com> wrote:
> >
> > On Tue Dec 1, 2020 at 8:33 AM MST, Alain Michaud wrote:
> > > Hi Luiz/Ronan,
> > >
> > > This appears to have been an incorrect fix since
> > > parse_mode_config(config, "BREDR", params, ARRAY_SIZE(params)); will
> > > attempt to read from the BREDR section. My suggestion would be to
> > > update the group table entry instead:
> >
> > Oh, that's right. Whoops.
> >
> > Updating the group table sounds good to me.

https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=e2863c003c8e65b386a981ef6037518beb605795

So now everything should be using BR as group name.


-- 
Luiz Augusto von Dentz