Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp500433pxu; Tue, 1 Dec 2020 17:22:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJzJh5BrwD1HhvhDfw3TDlczzOcOAB3CAtkOc/i6bPua0uudUVPIxG0lI+0Q1p8C39SmdiOl X-Received: by 2002:a17:906:768a:: with SMTP id o10mr116969ejm.212.1606872157118; Tue, 01 Dec 2020 17:22:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606872157; cv=none; d=google.com; s=arc-20160816; b=bjtcGoHoZFawhMlgSLCnO1u/JtW62pibS7xEA4V9lkSlxlO+LqME1MeHAGv3gc2/AY pi3d59iKLzoyu0419EA/JKXLSmTWmihBdDkexPwURJFP4cuEjEIWvhwT+EORf/z87oRY xcGOKTHJUyDDmePYpBSkJ8tDWZiimcoq0ufh19o21mT+yGL6ImqoJ2iXlFtW9x834Wa5 +euAxRnPNoDkic4fwQEXdSylvh5zlMj2YTm9e9RBMdaIU/1/tjCfOsgltMDDuuiyFpf1 wxnQfMTa7Nxpbn4zMi1NiEfEE2rWiBTalGQTxe2TxWSpGwhQXBz4uS4fANS4FsDGluhn todQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:sender:dkim-signature; bh=CpXBnYqZVf1ocOTpPEpGgiZ2rfyq5U/PDU+HX0vtfpk=; b=kZnwElfNClD11SyAAUsHinoQPLbZTMYl+onb7+d9hN9mScnBhuHo+ZY0eLCyVz5vEt GPMZtpMtcYWJQkch7aIrQB/PiVT/1pgq81kNwskMPwbyKhhAurpiFHGaHa/pm0WEOGZS LwLZtGA8cwVgD4s05/52Z/ht8i3FxjjhmHppfyayZQU176qYZwmnNmGa9aIorPsP9Onk JkQ+YofEiPUFK13gKtxLoplpmg1U5JBqHGJX4Pp0yTGygPKUf9i4k3ChMlmLjVYXaoaw LcVrKfDHjyJWdlVrAjaJaNSsEfqmw7/+6M4wkI1dR05jD6rc28dULgJjUBIQkeaud1jv jKdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=fbo5CxtS; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dc22si1066704ejb.568.2020.12.01.17.22.11; Tue, 01 Dec 2020 17:22:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=fbo5CxtS; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727798AbgLBBVc (ORCPT + 99 others); Tue, 1 Dec 2020 20:21:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727731AbgLBBVc (ORCPT ); Tue, 1 Dec 2020 20:21:32 -0500 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 140C5C0617A7 for ; Tue, 1 Dec 2020 17:20:52 -0800 (PST) Received: by mail-pl1-x649.google.com with SMTP id 9so174788plj.10 for ; Tue, 01 Dec 2020 17:20:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=CpXBnYqZVf1ocOTpPEpGgiZ2rfyq5U/PDU+HX0vtfpk=; b=fbo5CxtSUH2N/fwJxFrh2UVjMKn5QJDUzuh3ZmkD4QFmfKwWU61U45aVciSDJT1pQh tuMh7+LSooMsEn8LtEE+cHFs8IOYK3oy2TuBKNZAuz2esHt8eCArCGqOvAxw2+zN/Fvf Dp4VzTjF3zIZPtb8/ig2jXbf25FIbWXziEQpIO9hBv7FTUrL4VvTlNHU6bKc1UQh4lKJ X50F+iEM9aM4wc7Q+yWfMtRYshQ04WrA8+uboS1Q3p/uAVcDlWY9kZHNiC7QEQZcENkf o4/u20TX1berXR2JTaH6KIIDMd/1BVaYSJ2lMZVPo3W6oLT/47dv15ho2OrhThAeiBE0 V6Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=CpXBnYqZVf1ocOTpPEpGgiZ2rfyq5U/PDU+HX0vtfpk=; b=YIs2Ch5zx0E4R+iRU20JifjBW7OoTb0spHvWcCXzge35lp6QfH403LbCYbbIrOh/vm 8FFdETPhT/cokCALCRNdzidHaDClEKS/TLjZAxkcvb4mdCs33dK+g0XWy8RRhRqruPDX M+kdfkAt8WYGDqy+mENiLTbkyj9281vfGG4LM3ycB2gMuEa4ZKGfQdJgxV0aGLcJXqFZ zpL57X+RuSdB5zCyKZB7b7LPr3nPDEqQXsaxLQX4XHzv+1EyH2d0MjehzDkm/hyveQnY SgcoG8MPGDCcSkZkQu4uiRxMeEgA5hgnWiWNtNZT+4mUkZoRb+afLNaZwGeJyUtgOpVk 2+Tg== X-Gm-Message-State: AOAM530pY3hIUYljC3VTs8/0edmEGxMOsHuotULWWJu0RA9hONDfbW3C 4CQlIgo9YW5H1WaVi8xuqskoxQ1hep9/jw== Sender: "mmandlik via sendgmr" X-Received: from mmandlik.mtv.corp.google.com ([2620:15c:202:201:f693:9fff:fef4:e50e]) (user=mmandlik job=sendgmr) by 2002:a17:90a:460a:: with SMTP id w10mr50603pjg.1.1606872051318; Tue, 01 Dec 2020 17:20:51 -0800 (PST) Date: Tue, 1 Dec 2020 17:19:30 -0800 In-Reply-To: <20201202011930.2130671-1-mmandlik@google.com> Message-Id: <20201201171838.bluez.v1.3.Ic1f25ec863fe218390cfbe5e5252f787a4475d3b@changeid> Mime-Version: 1.0 References: <20201202011930.2130671-1-mmandlik@google.com> X-Mailer: git-send-email 2.29.2.454.gaff20da3a2-goog Subject: [bluez PATCH v1 3/3] client: Fix add advertisement monitor From: Manish Mandlik To: marcel@holtmann.org, luiz.dentz@gmail.com Cc: linux-bluetooth@vger.kernel.org, chromeos-bluetooth-upstreaming@chromium.org, Manish Mandlik , sonnysasaka@chromium.org, howardchung@google.com, mcchou@chromium.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org This patch fixes bluetoothctl add-monitor to emit InterfacesAdded/InterfacesRemoved signals correctly. Signed-off-by: Manish Mandlik Reviewed-by: sonnysasaka@chromium.org Reviewed-by: howardchung@google.com Reviewed-by: mcchou@chromium.org --- client/adv_monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/client/adv_monitor.c b/client/adv_monitor.c index 8e81857af..1d1745831 100644 --- a/client/adv_monitor.c +++ b/client/adv_monitor.c @@ -602,8 +602,9 @@ void adv_monitor_add_monitor(DBusConnection *conn, char *type, adv_monitor->patterns = patterns; adv_monitor->path = g_strdup_printf("%s/%hhu", ADV_MONITOR_APP_PATH, adv_mon_idx); - if (g_dbus_register_interface(conn, adv_monitor->path, + if (g_dbus_register_interface_full(conn, adv_monitor->path, ADV_MONITOR_INTERFACE, + ADV_MONITOR_APP_PATH, adv_monitor_methods, NULL, adv_monitor_props, adv_monitor, free_adv_monitor) == FALSE) { -- 2.29.2.454.gaff20da3a2-goog