Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201202011930.2130671-1-mmandlik@google.com> <20201201171838.bluez.v1.3.Ic1f25ec863fe218390cfbe5e5252f787a4475d3b@changeid>
In-Reply-To: <20201201171838.bluez.v1.3.Ic1f25ec863fe218390cfbe5e5252f787a4475d3b@changeid>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 2 Dec 2020 09:48:27 -0800
Message-ID: <CABBYNZL-Wek0k-pUe6Ta1wmcCCNJCj53EDdGij-Pka9QQb0=zA@mail.gmail.com>
Subject: Re: [bluez PATCH v1 3/3] client: Fix add advertisement monitor
To:     Manish Mandlik <mmandlik@google.com>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>,
        Sonny Sasaka <sonnysasaka@chromium.org>,
        Yun-hao Chung <howardchung@google.com>,
        Miao-chen Chou <mcchou@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Manish,

On Tue, Dec 1, 2020 at 5:20 PM Manish Mandlik <mmandlik@google.com> wrote:
>
> This patch fixes bluetoothctl add-monitor to emit
> InterfacesAdded/InterfacesRemoved signals correctly.
>
> Signed-off-by: Manish Mandlik <mmandlik@google.com>
> Reviewed-by: sonnysasaka@chromium.org
> Reviewed-by: howardchung@google.com
> Reviewed-by: mcchou@chromium.org
>
> ---
>
>  client/adv_monitor.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/client/adv_monitor.c b/client/adv_monitor.c
> index 8e81857af..1d1745831 100644
> --- a/client/adv_monitor.c
> +++ b/client/adv_monitor.c
> @@ -602,8 +602,9 @@ void adv_monitor_add_monitor(DBusConnection *conn, char *type,
>         adv_monitor->patterns = patterns;
>         adv_monitor->path = g_strdup_printf("%s/%hhu", ADV_MONITOR_APP_PATH,
>                                                                 adv_mon_idx);
> -       if (g_dbus_register_interface(conn, adv_monitor->path,
> +       if (g_dbus_register_interface_full(conn, adv_monitor->path,
>                                         ADV_MONITOR_INTERFACE,
> +                                       ADV_MONITOR_APP_PATH,
>                                         adv_monitor_methods, NULL,
>                                         adv_monitor_props, adv_monitor,
>                                         free_adv_monitor) == FALSE) {
> --
> 2.29.2.454.gaff20da3a2-goog

Nack, the right fix here is to use the real root path which is '"/"
just like is done in client/gatt.c

-- 
Luiz Augusto von Dentz